Differential D19443 Diff 46541 resources/sql/autopatches/20180509.repo_identity.commits.sql

Changeset View

Standalone View

				ALTER TABLE {$NAMESPACE}_repository.repository_commit
				ADD COLUMN authorIdentityPHID VARBINARY(64) DEFAULT NULL,
				ADD COLUMN committerIdentityPHID VARBINARY(64) DEFAULT NULL;
				amckinleyAuthorUnsubmitted Not Done Inline Actions I have mixed feelings about `DEFAULT NULL`. Right now it's required to get the unit tests to pass, because `PhabricatorRepositoryDiscoveryEngine` doesn't set these fields during discovery (I guess `PhabricatorRepositoryCommitMessageParserWorker->updateCommitData()` runs in a later phase?) Aside from that, I was developing with `NOT NULL` and it works fine, since `updateCommitData()` will definitely have a handle to the identity. amckinley: I have mixed feelings about `DEFAULT NULL`. Right now it's required to get the unit tests to…