Differential D19416 Diff 46450 src/applications/differential/controller/DifferentialRevisionViewController.php

Changeset View

Standalone View

src/applications/differential/controller/DifferentialRevisionViewController.php

Show First 20 Lines • Show All 147 Lines • ▼ Show 20 Lines	foreach ($field_list->getFields() as $key => $field) {
$object_phids[] = $phid;		$object_phids[] = $phid;
}		}
}		}

$handles = $this->loadViewerHandles($object_phids);		$handles = $this->loadViewerHandles($object_phids);

$request_uri = $request->getRequestURI();		$request_uri = $request->getRequestURI();

		// Revisions with more than 100 files are "large".
		// Revisions with more than 1000 files are "very large".
$limit = 100;		$limit = 100;
		amckinleyUnsubmitted Not Done Inline Actions And these comments should move to be closer to the code or removed. amckinley: And these comments should move to be closer to the code or removed.
$large = $request->getStr('large');		$large = $request->getStr('large');
if (count($changesets) > $limit && !$large) {
		$large_warning =
		(!$this->isVeryLargeDiff()) &&
		(count($changesets) > $limit) &&
		amckinleyUnsubmitted Not Done Inline Actions This became `$this->isLargeDiff()` in the stacked revision, right? amckinley: This became `$this->isLargeDiff()` in the stacked revision, right?
		(!$large);

		if ($large_warning) {
$count = count($changesets);		$count = count($changesets);
$warning = new PHUIInfoView();		$warning = new PHUIInfoView();
$warning->setTitle(pht('Large Diff'));		$warning->setTitle(pht('Large Diff'));
$warning->setSeverity(PHUIInfoView::SEVERITY_WARNING);		$warning->setSeverity(PHUIInfoView::SEVERITY_WARNING);
$warning->appendChild(hsprintf(		$warning->appendChild(hsprintf(
'%s <strong>%s</strong>',		'%s <strong>%s</strong>',
pht(		pht(
'This diff is large and affects %s files. '.		'This diff is large and affects %s files. '.
▲ Show 20 Lines • Show All 1,047 Lines • Show Last 20 Lines