Differential D19372 Diff 46346 src/applications/transactions/storage/PhabricatorApplicationTransaction.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
Show First 20 Lines • Show All 539 Lines • ▼ Show 20 Lines | /* -( Rendering )---------------------------------------------------------- */ | ||||
} | } | ||||
public function shouldHide() { | public function shouldHide() { | ||||
// Never hide comments. | // Never hide comments. | ||||
if ($this->hasComment()) { | if ($this->hasComment()) { | ||||
return false; | return false; | ||||
} | } | ||||
$xaction_type = $this->getTransactionType(); | |||||
// Always hide requests for object history. | |||||
if ($xaction_type === PhabricatorTransactions::TYPE_HISTORY) { | |||||
return true; | |||||
} | |||||
// Hide creation transactions if the old value is empty. These are | // Hide creation transactions if the old value is empty. These are | ||||
// transactions like "alice set the task tile to: ...", which are | // transactions like "alice set the task title to: ...", which are | ||||
// essentially never interesting. | // essentially never interesting. | ||||
if ($this->getIsCreateTransaction()) { | if ($this->getIsCreateTransaction()) { | ||||
switch ($this->getTransactionType()) { | switch ($xaction_type) { | ||||
case PhabricatorTransactions::TYPE_CREATE: | case PhabricatorTransactions::TYPE_CREATE: | ||||
case PhabricatorTransactions::TYPE_VIEW_POLICY: | case PhabricatorTransactions::TYPE_VIEW_POLICY: | ||||
case PhabricatorTransactions::TYPE_EDIT_POLICY: | case PhabricatorTransactions::TYPE_EDIT_POLICY: | ||||
case PhabricatorTransactions::TYPE_JOIN_POLICY: | case PhabricatorTransactions::TYPE_JOIN_POLICY: | ||||
case PhabricatorTransactions::TYPE_SPACE: | case PhabricatorTransactions::TYPE_SPACE: | ||||
break; | break; | ||||
case PhabricatorTransactions::TYPE_SUBTYPE: | case PhabricatorTransactions::TYPE_SUBTYPE: | ||||
return true; | return true; | ||||
▲ Show 20 Lines • Show All 1,068 Lines • Show Last 20 Lines |