Differential D19149 Diff 45874 resources/sql/autopatches/20180228.log.01.offset.sql

Changeset View

Standalone View

				ALTER TABLE {$NAMESPACE}_harbormaster.harbormaster_buildlogchunk
				ADD headOffset BIGINT UNSIGNED NOT NULL;

				ALTER TABLE {$NAMESPACE}_harbormaster.harbormaster_buildlogchunk
				ADD tailOffset BIGINT UNSIGNED NOT NULL;
				jcoxUnsubmitted Not Done Inline Actions Is there a reason that this is two statements instead of one? ie: ALTER TABLE {$NAMESPACE}_harbormaster.harbormaster_buildlogchunk ADD headOffset BIGINT UNSIGNED NOT NULL, ADD tailOffset BIGINT UNSIGNED NOT NULL; As-is, this patch rebuilds the table twice, which takes a very long time on our install (~3hrs each). It's not relevant for this case, but I imagine that T13088 will possibly lead to more alterations to the chunks table. If so, it'd be preferable to us if those changes were batched as much as possible. I believe that the above is valid in ~all flavors of mysql phab supports. jcox: Is there a reason that this is two statements instead of one? ie: ```ALTER TABLE…