Differential D18806 Diff 45278 src/applications/maniphest/application/PhabricatorManiphestApplication.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/maniphest/application/PhabricatorManiphestApplication.php
| Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Lines | final class PhabricatorManiphestApplication extends PhabricatorApplication { | ||||
| } | } | ||||
| public function getRoutes() { | public function getRoutes() { | ||||
| return array( | return array( | ||||
| '/T(?P<id>[1-9]\d*)' => 'ManiphestTaskDetailController', | '/T(?P<id>[1-9]\d*)' => 'ManiphestTaskDetailController', | ||||
| '/maniphest/' => array( | '/maniphest/' => array( | ||||
| '(?:query/(?P<queryKey>[^/]+)/)?' => 'ManiphestTaskListController', | '(?:query/(?P<queryKey>[^/]+)/)?' => 'ManiphestTaskListController', | ||||
| 'report/(?:(?P<view>\w+)/)?' => 'ManiphestReportController', | 'report/(?:(?P<view>\w+)/)?' => 'ManiphestReportController', | ||||
| 'batch/' => 'ManiphestBatchEditController', | $this->getBulkRoutePattern('bulk/') => 'ManiphestBulkEditController', | ||||
amckinley: Do we care about breaking any existing bookmarks using the old scheme? I can't think of why… | |||||
Not Done Inline ActionsYeah, I couldn't come up with a reason why you'd bookmark this. I could maybe imagine that you might have some internal tool that redirects to /batch/?ids=123 or whatever, or a bookmarklet that mangles Workboards, but you just need to replace /batch/ with /bulk/ if you do so that didn't seem like a huge issue. I don't have any direct knowledge of anyone doing this. epriestley: Yeah, I couldn't come up with a reason why you'd bookmark this.
I could maybe imagine that you… | |||||
| 'task/' => array( | 'task/' => array( | ||||
| $this->getEditRoutePattern('edit/') | $this->getEditRoutePattern('edit/') | ||||
| => 'ManiphestTaskEditController', | => 'ManiphestTaskEditController', | ||||
| ), | ), | ||||
| 'export/(?P<key>[^/]+)/' => 'ManiphestExportController', | 'export/(?P<key>[^/]+)/' => 'ManiphestExportController', | ||||
| 'subpriority/' => 'ManiphestSubpriorityController', | 'subpriority/' => 'ManiphestSubpriorityController', | ||||
| ), | ), | ||||
| ); | ); | ||||
| ▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines | |||||
Do we care about breaking any existing bookmarks using the old scheme? I can't think of why you'd bookmark a bulk edit link (but after this diff lands, it would be a little more likely).