Differential D18843 Diff 45203 src/applications/project/controller/PhabricatorProjectViewController.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/project/controller/PhabricatorProjectViewController.php
| Show All 14 Lines | public function handleRequest(AphrontRequest $request) { | ||||
| if ($response) { | if ($response) { | ||||
| return $response; | return $response; | ||||
| } | } | ||||
| $project = $this->getProject(); | $project = $this->getProject(); | ||||
| $engine = $this->getProfileMenuEngine(); | $engine = $this->getProfileMenuEngine(); | ||||
| $default = $engine->getDefaultItem(); | $default = $engine->getDefaultItem(); | ||||
| // If defaults are broken somehow, serve the manage page. See T13033 for | |||||
| // discussion. | |||||
| if ($default) { | |||||
| $default_key = $default->getBuiltinKey(); | |||||
| } else { | |||||
| $default_key = PhabricatorProject::ITEM_MANAGE; | |||||
| } | |||||
| switch ($default->getBuiltinKey()) { | switch ($default->getBuiltinKey()) { | ||||
zonr: Should this be `switch ($default_key)`? | |||||
| case PhabricatorProject::ITEM_WORKBOARD: | case PhabricatorProject::ITEM_WORKBOARD: | ||||
| $controller_object = new PhabricatorProjectBoardViewController(); | $controller_object = new PhabricatorProjectBoardViewController(); | ||||
| break; | break; | ||||
| case PhabricatorProject::ITEM_PROFILE: | case PhabricatorProject::ITEM_PROFILE: | ||||
| $controller_object = new PhabricatorProjectProfileController(); | $controller_object = new PhabricatorProjectProfileController(); | ||||
| break; | break; | ||||
| case PhabricatorProject::ITEM_MANAGE: | |||||
| $controller_object = new PhabricatorProjectManageController(); | |||||
| break; | |||||
| default: | default: | ||||
| return $engine->buildResponse(); | return $engine->buildResponse(); | ||||
| } | } | ||||
| return $this->delegateToController($controller_object); | return $this->delegateToController($controller_object); | ||||
| } | } | ||||
| } | } | ||||
Should this be switch ($default_key)?