Differential D18714 Diff 44929 src/applications/differential/customfield/DifferentialDraftField.php

Changeset View

Standalone View

src/applications/differential/customfield/DifferentialDraftField.php

This file was added.

				<?php

				final class DifferentialDraftField
				extends DifferentialCoreCustomField {

				public function getFieldKey() {
				return 'differential:draft';
				}

				public function getFieldName() {
				return pht('Draft');
				}

				public function getFieldDescription() {
				return pht('Show a warning about draft revisions.');
				}

				protected function readValueFromRevision(
				DifferentialRevision $revision) {
				return null;
				}

				public function shouldAppearInPropertyView() {
				return true;
				}

				public function renderPropertyViewValue() {
				return null;
				}

				public function getWarningsForRevisionHeader(array $handles) {
				$viewer = $this->getViewer();
				$revision = $this->getObject();

				if (!$revision->isDraft()) {
				return array();
				}

				$warnings = array();

				$blocking_map = array(
				HarbormasterBuildStatus::STATUS_FAILED,
				HarbormasterBuildStatus::STATUS_ABORTED,
				HarbormasterBuildStatus::STATUS_ERROR,
				HarbormasterBuildStatus::STATUS_PAUSED,
				HarbormasterBuildStatus::STATUS_DEADLOCKED,
				);
				$blocking_map = array_fuse($blocking_map);
				amckinleyUnsubmitted Not Done Inline Actions Maybe we should invert this and enumerate the non-blocking states? (Looks like there are 4 of those vs 5 of these). Or add a `HarbormasterBuildStatus::getFailedStatusConstants()` to make it more likely that this code will continue to work if we add more failed states? amckinley: Maybe we should invert this and enumerate the non-blocking states? (Looks like there are 4 of…

				$builds = $revision->loadActiveBuilds($viewer);

				$waiting = array();
				$blocking = array();
				foreach ($builds as $build) {
				if (isset($blocking_map[$build->getBuildStatus()])) {
				$blocking[] = $build;
				} else {
				$waiting[] = $build;
				}
				}

				$blocking_list = $viewer->renderHandleList(mpull($blocking, 'getPHID'))
				->setAsInline(true);
				$waiting_list = $viewer->renderHandleList(mpull($waiting, 'getPHID'))
				->setAsInline(true);

				if ($blocking) {
				$warnings[] = pht(
				'This draft revision will not be submitted for review because %s '.
				'build(s) failed: %s.',
				phutil_count($blocking),
				$blocking_list);
				$warnings[] = pht(
				'Fix build failures and update the revision.');
				} else if ($waiting) {
				$warnings[] = pht(
				'This draft revision will be sent for review once %s '.
				'build(s) pass: %s.',
				phutil_count($waiting),
				$waiting_list);
				} else {
				$warnings[] = pht(
				'This is a draft revision that has not yet been submitted for '.
				'review.');
				}

				return $warnings;
				}

				}