Differential D18599 Diff 44663 src/applications/differential/controller/DifferentialRevisionOperationController.php

Changeset View

Standalone View

src/applications/differential/controller/DifferentialRevisionOperationController.php

Show First 20 Lines • Show All 131 Lines • ▼ Show 20 Lines	private function loadDefaultRef(
PhabricatorRepository $repository,		PhabricatorRepository $repository,
DifferentialDiff $diff) {		DifferentialDiff $diff) {
$default_name = $this->getDefaultRefName($repository, $diff);		$default_name = $this->getDefaultRefName($repository, $diff);

if (!strlen($default_name)) {		if (!strlen($default_name)) {
return null;		return null;
}		}

return $this->newRefQuery($repository)		// NOTE: See PHI68. This is a workaround to make "Land Revision" work
		// until T11823 is fixed properly. If we find multiple refs with the same
		// name (normally, duplicate "master" refs), just pick the first one.

		$refs = $this->newRefQuery($repository)
->withRefNames(array($default_name))		->withRefNames(array($default_name))
->executeOne();		->execute();

		if ($refs) {
		return head($refs);
		amckinleyUnsubmitted Not Done Inline Actions Is it worth putting something in the logs when we hit this so we can track how frequently we're seeing it in practice? amckinley: Is it worth putting something in the logs when we hit this so we can track how frequently we're…
		}

		return null;
}		}

private function getDefaultRefName(		private function getDefaultRefName(
PhabricatorRepository $repository,		PhabricatorRepository $repository,
DifferentialDiff $diff) {		DifferentialDiff $diff) {

$onto = $diff->loadTargetBranch();		$onto = $diff->loadTargetBranch();
if ($onto !== null) {		if ($onto !== null) {
return $onto;		return $onto;
}		}

return $repository->getDefaultBranch();		return $repository->getDefaultBranch();
}		}

}		}