Differential D18414 Diff 44258 src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php

Changeset View

Standalone View

src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php

Show First 20 Lines • Show All 145 Lines • ▼ Show 20 Lines	foreach ($objects as $key => $object) {
unset($this->objects[$key]);		unset($this->objects[$key]);
}		}

return $results;		return $results;
}		}

private function filterShouldUpdate(array $phids) {		private function filterShouldUpdate(array $phids) {
$statuses = array(		$statuses = array(
ArcanistDifferentialRevisionStatus::NEEDS_REVISION,		DifferentialRevisionStatus::NEEDS_REVISION,
ArcanistDifferentialRevisionStatus::CHANGES_PLANNED,		DifferentialRevisionStatus::CHANGES_PLANNED,
ArcanistDifferentialRevisionStatus::IN_PREPARATION,
);		);
$statuses = array_fuse($statuses);		$statuses = array_fuse($statuses);

$objects = $this->getRevisionsAuthored($this->objects, $phids);		$objects = $this->getRevisionsAuthored($this->objects, $phids);

$results = array();		$results = array();
foreach ($objects as $key => $object) {		foreach ($objects as $key => $object) {
if (empty($statuses[$object->getStatus()])) {		if (empty($statuses[$object->getModernRevisionStatus()])) {
continue;		continue;
}		}

$results[$key] = $object;		$results[$key] = $object;
unset($this->objects[$key]);		unset($this->objects[$key]);
}		}

return $results;		return $results;
Show All 12 Lines	foreach ($objects as $key => $object) {
unset($this->objects[$key]);		unset($this->objects[$key]);
}		}

return $results;		return $results;
}		}

private function filterWaitingOnAuthors(array $phids) {		private function filterWaitingOnAuthors(array $phids) {
$statuses = array(		$statuses = array(
ArcanistDifferentialRevisionStatus::ACCEPTED,		DifferentialRevisionStatus::ACCEPTED,
ArcanistDifferentialRevisionStatus::NEEDS_REVISION,		DifferentialRevisionStatus::NEEDS_REVISION,
ArcanistDifferentialRevisionStatus::CHANGES_PLANNED,		DifferentialRevisionStatus::CHANGES_PLANNED,
ArcanistDifferentialRevisionStatus::IN_PREPARATION,
);		);
$statuses = array_fuse($statuses);		$statuses = array_fuse($statuses);

$objects = $this->getRevisionsNotAuthored($this->objects, $phids);		$objects = $this->getRevisionsNotAuthored($this->objects, $phids);

$results = array();		$results = array();
foreach ($objects as $key => $object) {		foreach ($objects as $key => $object) {
if (empty($statuses[$object->getStatus()])) {		if (empty($statuses[$object->getModernRevisionStatus()])) {
continue;		continue;
}		}

$results[$key] = $object;		$results[$key] = $object;
unset($this->objects[$key]);		unset($this->objects[$key]);
}		}

return $results;		return $results;
Show All 40 Lines