Differential D18339 Diff 44158 src/applications/differential/customfield/DifferentialReviewersField.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/differential/customfield/DifferentialReviewersField.php
| Show First 20 Lines • Show All 62 Lines • ▼ Show 20 Lines | final class DifferentialReviewersField | ||||
| public function getRequiredHandlePHIDsForRevisionHeaderWarnings() { | public function getRequiredHandlePHIDsForRevisionHeaderWarnings() { | ||||
| return mpull($this->getValue(), 'getReviewerPHID'); | return mpull($this->getValue(), 'getReviewerPHID'); | ||||
| } | } | ||||
| public function getWarningsForRevisionHeader(array $handles) { | public function getWarningsForRevisionHeader(array $handles) { | ||||
| $revision = $this->getObject(); | $revision = $this->getObject(); | ||||
| $status_needs_review = ArcanistDifferentialRevisionStatus::NEEDS_REVIEW; | if (!$revision->isNeedsReview()) { | ||||
| if ($revision->getStatus() != $status_needs_review) { | |||||
| return array(); | return array(); | ||||
| } | } | ||||
| foreach ($this->getValue() as $reviewer) { | foreach ($this->getValue() as $reviewer) { | ||||
| if (!$handles[$reviewer->getReviewerPHID()]->isDisabled()) { | if (!$handles[$reviewer->getReviewerPHID()]->isDisabled()) { | ||||
| return array(); | return array(); | ||||
| } | } | ||||
| } | } | ||||
| Show All 15 Lines | |||||