Differential D18351 Diff 44107 src/lint/linter/xhpast/rules/ArcanistNamespaceFirstStatementXHPASTLinterRule.php

Changeset View

Standalone View

src/lint/linter/xhpast/rules/ArcanistNamespaceFirstStatementXHPASTLinterRule.php

	<?php			<?php

	final class ArcanistNamespaceFirstStatementXHPASTLinterRule			final class ArcanistNamespaceFirstStatementXHPASTLinterRule
	extends ArcanistXHPASTLinterRule {			extends ArcanistXHPASTLinterRule {

	const ID = 98;			const ID = 98;

	public function getLintName() {			public function getLintName() {
	return pht('`%s` Statement Must Be The First Statement', 'namespace');			return pht('`%s` Statement Must Be The First Statement Or After Only `%s`
				joshuaspenceUnsubmitted Not Done Inline Actions Given that the documentation lists this an an exception, I think it's fine to leave the name as-is. joshuaspence: Given that the documentation lists this an an exception, I think it's fine to leave the name as…
				calls', 'namespace', 'declare');
	}			}

	public function process(XHPASTNode $root) {			public function process(XHPASTNode $root) {
	$namespaces = $root->selectDescendantsOfType('n_NAMESPACE');			$namespaces = $root->selectDescendantsOfType('n_NAMESPACE');

	if (!count($namespaces)) {			if (!count($namespaces)) {
	return;			return;
	}			}

	$statements = $root->getChildOfType(0, 'n_STATEMENT_LIST');			$statements = $root->getChildOfType(0, 'n_STATEMENT_LIST');

	// Ignore the first statement, which should be `n_OPEN_TAG`.			foreach ($statements->getChildren() as $statement) {
	$second_statement = $statements->getChildByIndex(1)->getChildByIndex(0);			if ($statement->getTypeName() === 'n_OPEN_TAG') {
				continue;
	if ($second_statement->getTypeName() != 'n_NAMESPACE') {			}
				$statement_type = $statement->getChildByIndex(0)->getTypeName();
				if ($statement_type === 'n_DECLARE') {
				continue;
				} else if ($statement_type !== 'n_NAMESPACE') {
	$this->raiseLintAtNode(			$this->raiseLintAtNode(
	$second_statement,			$statement,
	pht(			pht(
	'A script which contains a `%s` statement expects the very first '.			'A script which contains a `%s` statement expects it is the very '.
	'statement to be a `%s` statement. Otherwise, a PHP fatal error '.			'first statement or only after `%s` statements. Otherwise, a PHP '.
	'will occur. %s',			'fatal error will occur. %s',
	'namespace',			'namespace',
	'namespace', $second_statement->getTypeName()));			'declare',
				$statement_type));
				} else {
				break;
				}
	}			}
	}			}

	}			}