Differential D18160 Diff 43688 src/applications/config/type/PhabricatorSetConfigType.php

Changeset View

Standalone View

src/applications/config/type/PhabricatorSetConfigType.php

This file was added.

				<?php

				final class PhabricatorSetConfigType
				extends PhabricatorTextConfigType {

				const TYPEKEY = 'set';

				protected function newControl(PhabricatorConfigOption $option) {
				return id(new AphrontFormTextAreaControl())
				->setCaption(pht('Separate values with newlines or commas.'));
				}

				protected function newCanonicalValue(
				PhabricatorConfigOption $option,
				$value) {

				$value = preg_split('/[\n,]+/', $value);
				foreach ($value as $k => $v) {
				if (!strlen($v)) {
				unset($value[$k]);
				}
				$value[$k] = trim($v);
				}

				return array_fill_keys($value, true);
				}

				public function newValueFromCommandLineValue(
				PhabricatorConfigOption $option,
				$value) {

				try {
				$value = phutil_json_decode($value);
				} catch (Exception $ex) {
				throw $this->newException(
				pht(
				'Option "%s" is of type "%s", but the value you provided is not a '.
				'valid JSON set. When providing a set from the command '.
				amckinleyUnsubmitted Not Done Inline Actions Technically, there's no such thing as a JSON set? amckinley: Technically, there's no such thing as a JSON set?
				'line, specify the value in JSON. You may need to quote the '.
				epriestleyAuthorUnsubmitted Not Done Inline Actions I'll wordsmith this, it's a little copy/pastey. epriestley: I'll wordsmith this, it's a little copy/pastey.
				'value for your shell (for example: \'["a", "b", ...]\').',
				$option->getKey(),
				$this->getTypeKey()));
				}

				if ($value) {
				if (array_keys($value) !== range(0, count($value) - 1)) {
				throw $this->newException(
				pht(
				'Option "%s" is of type "%s", and should be specified on the '.
				'command line as a JSON list of values. You may need to quote '.
				'the value for your shell (for example: \'["a", "b", ...]\').',
				$option->getKey(),
				$this->getTypeKey()));
				}
				}

				return array_fill_keys($value, true);
				}

				public function newDisplayValue(
				PhabricatorConfigOption $option,
				$value) {
				return implode("\n", array_keys($value));
				}

				public function validateStoredValue(
				PhabricatorConfigOption $option,
				$value) {

				if (!is_array($value)) {
				throw $this->newException(
				pht(
				'Option "%s" is of type "%s", but the configured value is not '.
				'a list.',
				$option->getKey(),
				$this->getTypeKey()));
				}

				$expect_key = 0;
				amckinleyUnsubmitted Not Done Inline Actions Unused variable. amckinley: Unused variable.
				foreach ($value as $k => $v) {
				if ($v !== true) {
				amckinleyUnsubmitted Not Done Inline Actions This took a minute to grok, but this is because our `set` type is really just a regular JSON list that gets converted into a PHP array that maps all keys to `true`, right? amckinley: This took a minute to grok, but this is because our `set` type is really just a regular JSON…
				throw $this->newException(
				epriestleyAuthorUnsubmitted Not Done Inline Actions `$v` is used here. epriestley: `$v` is used here.
				amckinleyUnsubmitted Not Done Inline Actions Oh whoops, I tagged the wrong line. It's one up, `$expect_key`. amckinley: Oh whoops, I tagged the wrong line. It's one up, `$expect_key`.
				pht(
				'Option "%s" is of type "%s", but the value at index "%s" of the '.
				'list is not "true".',
				$option->getKey(),
				$this->getTypeKey(),
				$k));
				}
				epriestleyAuthorUnsubmitted Not Done Inline Actions `$k` is used here. epriestley: `$k` is used here.
				}
				}

				}