Differential D17783 Diff 42867 src/lint/linter/standards/__tests__/ArcanistLinterStandardTestCase.php

Changeset View

Standalone View

	<?php			<?php

	final class ArcanistLinterStandardTestCase extends PhutilTestCase {			abstract class ArcanistLinterStandardTestCase
				extends ArcanistLinterTestCase {
				joshuaspenceUnsubmitted Done Inline Actions You should extend `ArcanistLinterTestCase` instead joshuaspence: You should extend `ArcanistLinterTestCase` instead

	public function testLoadAllStandards() {			public function testLoadAllStandards() {
	ArcanistLinterStandard::loadAllStandards();			ArcanistLinterStandard::loadAllStandards();
	$this->assertTrue(true);			$this->assertTrue(true);
				joshuaspenceUnsubmitted Done Inline Actions Maybe call this `getBaseLinter`? joshuaspence: Maybe call this `getBaseLinter`?
	}			}
	joshuaspenceUnsubmitted Done Inline Actions You might want to leave this. joshuaspence: You //might// want to leave this.

				joshuaspenceUnsubmitted Done Inline Actions I think this should be called `getStandard` joshuaspence: I think this should be called `getStandard`
				abstract protected function getBaseLinter();

				abstract protected function getStandard();

				protected function getLinter() {
				$linter = $this->getBaseLinter();
				$linter->applyStandard($this->getStandard());

				joshuaspenceUnsubmitted Done Inline Actions Ideally, we should have some sort of `$linter->applyStandard($standard)` method... because this code is currently duplicated from `ArcanistLinter` joshuaspence: Ideally, we should have some sort of `$linter->applyStandard($standard)` method... because this…
				return $linter;
				}

	}			}