Differential D15743 Diff 42622 src/applications/files/controller/PhabricatorFileDeleteController.php

Changeset View

Standalone View

src/applications/files/controller/PhabricatorFileDeleteController.php

	<?php			<?php

	final class PhabricatorFileDeleteController extends PhabricatorFileController {			final class PhabricatorFileDeleteController extends PhabricatorFileController {

	public function handleRequest(AphrontRequest $request) {			public function handleRequest(AphrontRequest $request) {
	$viewer = $request->getViewer();			$viewer = $request->getViewer();
	$id = $request->getURIData('id');			$id = $request->getURIData('id');

	$file = id(new PhabricatorFileQuery())			$file = id(new PhabricatorFileQuery())
	->setViewer($viewer)			->setViewer($viewer)
	->withIDs(array($id))			->withIDs(array($id))
				->withIsDeleted(false)
	->requireCapabilities(			->requireCapabilities(
	array(			array(
	PhabricatorPolicyCapability::CAN_VIEW,			PhabricatorPolicyCapability::CAN_VIEW,
	PhabricatorPolicyCapability::CAN_EDIT,			PhabricatorPolicyCapability::CAN_EDIT,
	))			))
	->executeOne();			->executeOne();
	if (!$file) {			if (!$file) {
	return new Aphront404Response();			return new Aphront404Response();
	}			}

	if (($viewer->getPHID() != $file->getAuthorPHID()) &&			if (($viewer->getPHID() != $file->getAuthorPHID()) &&
	(!$viewer->getIsAdmin())) {			(!$viewer->getIsAdmin())) {
	return new Aphront403Response();			return new Aphront403Response();
	}			}

	if ($request->isFormPost()) {			if ($request->isFormPost()) {
	$engine = new PhabricatorDestructionEngine();			// Mark the file for deletion, save it, and schedule a worker to
	$engine->destroyObject($file);			// sweep by later and pick it up.
				$file->setIsDeleted(true)->save();

				PhabricatorWorker::scheduleTask(
				'FileDeletionWorker',
				array('objectPHID' => $file->getPHID()),
				array('priority' => PhabricatorWorker::PRIORITY_BULK));
				epriestleyUnsubmitted Done Inline Actions Maybe drop the priority on these to `PRIORITY_BULK` -- they're probably less important to complete in a timely fashion than most other tasks. Also, for completeness, specify `'objectPHID' => $file->getPHID()` here. Doing so allows us to find tasks affecting a given file later. epriestley: Maybe drop the priority on these to `PRIORITY_BULK` -- they're probably less important to…

	return id(new AphrontRedirectResponse())->setURI('/file/');			return id(new AphrontRedirectResponse())->setURI('/file/');
	}			}

	return $this->newDialog()			return $this->newDialog()
	->setTitle(pht('Really delete file?'))			->setTitle(pht('Really delete file?'))
	->appendChild(hsprintf(			->appendChild(hsprintf(
	'<p>%s</p>',			'<p>%s</p>',
	pht(			pht(
	'Permanently delete "%s"? This action can not be undone.',			'Permanently delete "%s"? This action can not be undone.',
	$file->getName())))			$file->getName())))
	->addSubmitButton(pht('Delete'))			->addSubmitButton(pht('Delete'))
	->addCancelButton($file->getInfoURI());			->addCancelButton($file->getInfoURI());
	}			}
	}			}