Changeset View
Changeset View
Standalone View
Standalone View
src/applications/config/option/PhabricatorClusterConfigOptions.php
Show All 32 Lines | EOTEXT | ||||
, | , | ||||
PhabricatorEnv::getDoclink('Cluster: Databases'), | PhabricatorEnv::getDoclink('Cluster: Databases'), | ||||
pht('Cluster: Databases'))); | pht('Cluster: Databases'))); | ||||
$intro_href = PhabricatorEnv::getDoclink('Clustering Introduction'); | $intro_href = PhabricatorEnv::getDoclink('Clustering Introduction'); | ||||
$intro_name = pht('Clustering Introduction'); | $intro_name = pht('Clustering Introduction'); | ||||
$search_type = 'custom:PhabricatorClusterSearchConfigOptionType'; | |||||
$search_help = $this->deformat(pht(<<<EOTEXT | |||||
Define one or more fulltext storage services. Here you can configure which | |||||
epriestley: Maybe "storage services" instead of "storage clusters"? I think that's slightly more consistent… | |||||
hosts will handle fulltext search queries and indexing. For help with | |||||
Done Inline ActionsMaybe just get rid of the MySQL/Elastic mention, since we'll probably forget to update this if/when we add more support and third-parties can add support for other engines but can't easily update this string (and maybe we'll spin out Elastic into an extension after Packages actually works). If you prefer to name the services explicitly, maybe say something like "MySQL, ElasticSearch, or other engines" so we have more room to add or remove support in the future without this text becoming misleading. epriestley: Maybe just get rid of the MySQL/Elastic mention, since we'll probably forget to update this… | |||||
configuring fulltext search clusters, see **[[ %s | %s ]]** in the | |||||
documentation. | |||||
EOTEXT | |||||
, | |||||
PhabricatorEnv::getDoclink('Cluster: Search'), | |||||
pht('Cluster: Search'))); | |||||
return array( | return array( | ||||
$this->newOption('cluster.addresses', 'list<string>', array()) | $this->newOption('cluster.addresses', 'list<string>', array()) | ||||
->setLocked(true) | ->setLocked(true) | ||||
->setSummary(pht('Address ranges of cluster hosts.')) | ->setSummary(pht('Address ranges of cluster hosts.')) | ||||
->setDescription( | ->setDescription( | ||||
pht( | pht( | ||||
'Define a Phabricator cluster by providing a whitelist of host '. | 'Define a Phabricator cluster by providing a whitelist of host '. | ||||
'addresses that are part of the cluster.'. | 'addresses that are part of the cluster.'. | ||||
▲ Show 20 Lines • Show All 60 Lines • ▼ Show 20 Lines | return array( | ||||
'into this mode automatically when it detects that the database '. | 'into this mode automatically when it detects that the database '. | ||||
'master is unreachable, but you can activate it manually in '. | 'master is unreachable, but you can activate it manually in '. | ||||
'order to perform maintenance or test configuration.')), | 'order to perform maintenance or test configuration.')), | ||||
$this->newOption('cluster.databases', $databases_type, array()) | $this->newOption('cluster.databases', $databases_type, array()) | ||||
->setHidden(true) | ->setHidden(true) | ||||
->setSummary( | ->setSummary( | ||||
pht('Configure database read replicas.')) | pht('Configure database read replicas.')) | ||||
->setDescription($databases_help), | ->setDescription($databases_help), | ||||
$this->newOption('cluster.search', $search_type, array()) | |||||
->setLocked(true) | |||||
->setSummary( | |||||
pht('Configure full-text search services.')) | |||||
->setDescription($search_help) | |||||
->setDefault( | |||||
array( | |||||
array( | |||||
'type' => 'mysql', | |||||
'roles' => array( | |||||
'read' => true, | |||||
'write' => true, | |||||
), | |||||
), | |||||
)), | |||||
); | ); | ||||
} | } | ||||
} | } |
Maybe "storage services" instead of "storage clusters"? I think that's slightly more consistent with other teminology.