Differential D17499 Diff 42085 src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
| Show First 20 Lines • Show All 522 Lines • ▼ Show 20 Lines | $can_use_badges = PhabricatorApplication::isClassInstalledForViewer( | ||||
| $user); | $user); | ||||
| if (!$can_use_badges) { | if (!$can_use_badges) { | ||||
| return null; | return null; | ||||
| } | } | ||||
| $awards = id(new PhabricatorBadgesAwardQuery()) | $awards = id(new PhabricatorBadgesAwardQuery()) | ||||
| ->setViewer($this->getUser()) | ->setViewer($this->getUser()) | ||||
| ->withRecipientPHIDs(array($user->getPHID())) | ->withRecipientPHIDs(array($user->getPHID())) | ||||
| ->withBadgeStatuses(array(PhabricatorBadgesBadge::STATUS_ACTIVE)) | |||||
| ->setLimit(2) | ->setLimit(2) | ||||
| ->execute(); | ->execute(); | ||||
| $badge_view = null; | |||||
| if ($awards) { | |||||
| $badges = mpull($awards, 'getBadge'); | $badges = mpull($awards, 'getBadge'); | ||||
| $badge_view = null; | |||||
| if ($badges) { | |||||
| $badge_list = array(); | $badge_list = array(); | ||||
epriestley: This change (away from `setLimit()`) means that we load //every// award the user has ever… | |||||
Not Done Inline Actionsdoes setLimit work with filterPage? I assumed if I had 4 badges, and 1 was archived, only 1 might be returned. chad: does `setLimit` work with filterPage? I assumed if I had 4 badges, and 1 was archived, only 1… | |||||
| foreach ($badges as $badge) { | foreach ($badges as $badge) { | ||||
| $badge_view = id(new PHUIBadgeMiniView()) | $badge_view = id(new PHUIBadgeMiniView()) | ||||
| ->setIcon($badge->getIcon()) | ->setIcon($badge->getIcon()) | ||||
| ->setQuality($badge->getQuality()) | ->setQuality($badge->getQuality()) | ||||
| ->setHeader($badge->getName()) | ->setHeader($badge->getName()) | ||||
| ->setTipDirection('E') | ->setTipDirection('E') | ||||
| ->setHref('/badges/view/'.$badge->getID()); | ->setHref('/badges/view/'.$badge->getID()); | ||||
| Show All 17 Lines | |||||
This change (away from setLimit()) means that we load every award the user has ever received (which could be thousands), then throw away all but two. What issue were you hitting that prompted you to remove setLimit()?