Differential D17492 Diff 42076 src/applications/dashboard/controller/PhabricatorDashboardInstallController.php

Changeset View

Standalone View

src/applications/dashboard/controller/PhabricatorDashboardInstallController.php

This file was added.

				<?php

				final class PhabricatorDashboardInstallController
				extends PhabricatorDashboardController {

				public function handleRequest(AphrontRequest $request) {
				$viewer = $request->getViewer();
				$id = $request->getURIData('id');

				$dashboard = id(new PhabricatorDashboardQuery())
				->setViewer($viewer)
				->withIDs(array($id))
				->executeOne();
				if (!$dashboard) {
				epriestleyUnsubmitted Done Inline Actions Does this actually need panels? epriestley: Does this actually need panels?
				return new Aphront404Response();
				}

				epriestleyUnsubmitted Not Done Inline Actions You can drop this now since it's the default behavior. epriestley: You can drop this now since it's the default behavior.
				$cancel_uri = $this->getApplicationURI(
				'view/'.$dashboard->getID().'/');

				$home_app = new PhabricatorHomeApplication();

				$options = array();
				$options['home'] = array(
				'personal' =>
				array(
				'capability' => PhabricatorPolicyCapability::CAN_VIEW,
				'application' => $home_app,
				'name' => pht('Personal Dashboard'),
				'value' => 'personal',
				'description' => pht('Places this dashboard as a menu item on home '.
				'as a personal menu item. It will only be on your personal '.
				'home.'),
				),
				epriestleyUnsubmitted Done Inline Actions "as the a" -> "as a" epriestley: "as the a" -> "as a"
				'global' =>
				epriestleyUnsubmitted Done Inline Actions "You can change this after by editing..." reads awkwardly to me, although I'm not sure it's really grammatically incorrect. This seems pretty much impossible to Google because the word "after" is used frequently when discussing grammar in general. I think it's because "after" is a preposition, not an adverb? Maybe consider: You can change this later by editing... You can change this afterwards by editing... You can change this after installing by editing... After installing, you can change this by editing... epriestley: "You can change this after by editing..." reads awkwardly to me, although I'm not sure it's…
				array(
				'capability' => PhabricatorPolicyCapability::CAN_EDIT,
				'application' => $home_app,
				'name' => pht('Global Dashboard'),
				'value' => 'global',
				'description' => pht('Places this dashboard as a menu item on home '.
				'as a global menu item. It will be available to all users.'),
				),
				);


				$errors = array();
				$v_name = null;
				if ($request->isFormPost()) {
				$menuitem = new PhabricatorDashboardProfileMenuItem();
				$dashboard_phid = $dashboard->getPHID();
				$home = new PhabricatorHomeApplication();
				$v_name = $request->getStr('name');
				$v_home = $request->getStr('home');

				if ($v_home) {
				$application = $options['home'][$v_home]['application'];
				$capability = $options['home'][$v_home]['capability'];

				$can_edit_home = PhabricatorPolicyFilter::hasCapability(
				$viewer,
				$application,
				$capability);

				if (!$can_edit_home) {
				$errors[] = pht(
				'You do not have permission to install a dashboard on home.');
				}
				} else {
				$errors[] = pht(
				'You must select a destination to install this dashboard.');
				}

				$v_phid = $viewer->getPHID();
				if ($v_home == 'global') {
				$v_phid = null;
				}

				if (!$errors) {
				$install = PhabricatorProfileMenuItemConfiguration::initializeNewItem(
				$home,
				$menuitem,
				$v_phid);

				$install->setMenuItemProperty('dashboardPHID', $dashboard_phid);
				$install->setMenuItemProperty('name', $v_name);
				$install->setMenuItemOrder(1);

				$xactions = array();

				$editor = id(new PhabricatorProfileMenuEditor())
				->setActor($viewer)
				->setContinueOnNoEffect(true)
				->setContinueOnMissingFields(true)
				->setContentSourceFromRequest($request);

				$editor->applyTransactions($install, $xactions);

				$view_uri = '/home/menu/view/'.$install->getID().'/';

				return id(new AphrontRedirectResponse())->setURI($view_uri);
				}
				}

				$form = id(new AphrontFormView())
				->setUser($viewer)
				->appendChild(
				id(new AphrontFormTextControl())
				->setLabel(pht('Menu Label'))
				->setName('name')
				->setValue($v_name));

				$radio = id(new AphrontFormRadioButtonControl())
				->setLabel(pht('Home Menu'))
				->setName('home');

				foreach ($options['home'] as $type => $option) {
				$can_edit = PhabricatorPolicyFilter::hasCapability(
				$viewer,
				$option['application'],
				$option['capability']);
				if ($can_edit) {
				$radio->addButton(
				$option['value'],
				$option['name'],
				$option['description']);
				}
				}

				$form->appendChild($radio);

				return $this->newDialog()
				->setTitle(pht('Install Dashboard'))
				->setErrors($errors)
				->setWidth(AphrontDialogView::WIDTH_FORM)
				->appendChild($form->buildLayoutView())
				->addCancelButton($cancel_uri)
				chadAuthorUnsubmitted Not Done Inline Actions This is causing permission errors if you're not an admin. Is there a way to "check" permissions, and not require them? chad: This is causing permission errors if you're not an admin. Is there a way to "check" permissions…
				epriestleyUnsubmitted Not Done Inline Actions After loading the object, you can `PhabricatorPolicyFilter::hasCapability(...)` to test for edit permission without raising exceptions. epriestley: After loading the object, you can `PhabricatorPolicyFilter::hasCapability(...)` to test for…
				->addSubmitButton(pht('Install Dashboard'));
				}

				}