Differential D17384 Diff 42049 src/applications/search/fulltextstorage/PhabricatorElasticSearchQueryBuilder.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/search/fulltextstorage/PhabricatorElasticSearchQueryBuilder.php
- This file was added.
For consistency, prefer getClauseCount(). Using a small set of consistent verb avoids ambiguity with method names like empty(), where it could mean isThisEmpty() or makeThisEmptyByDeletingAllOfTheStuff(), which are very different.
The rest of these methods are probably fine since they're specific to ElasticSearch, although maybe consider more explicit methods: addMustClause(), addFilterClause(), etc.