Differential D17464 Diff 42000 src/applications/people/management/PhabricatorPeopleManagementWorkflow.php

Changeset View

Standalone View

				<?php

				abstract class PhabricatorPeopleManagementWorkflow
				extends PhabricatorManagementWorkflow {

				protected function buildIterator(PhutilArgumentParser $args) {
				$usernames = $args->getArg('users');

				if ($args->getArg('all')) {
				if ($usernames) {
				throw new PhutilArgumentUsageException(
				pht(
				'Specify either a list of users or `%s`, but not both.',
				'--all'));
				}
				return new LiskMigrationIterator(new PhabricatorUser());
				}

				if ($usernames) {
				return $this->loadUsersWithUsernames($usernames);
				}

				return null;
				}

				protected function loadUsersWithUsernames(array $usernames) {
				$users = array();
				foreach($usernames as $username) {
				$query = id(new PhabricatorPeopleQuery())
				->setViewer($this->getViewer())
				->withUsernames(array($username))
				->executeOne();
				epriestleyUnsubmitted Not Done Inline Actions Ideally, make sure that we loaded a user for each username. As written, I think `profileimage alinkern bartty claire` will "work": as long as you provide at least one valid username, we'll just ignore the invalid ones. Better would be to fatal explicitly before doing anything: "user alinkern is not a valid user". epriestley: Ideally, make sure that we loaded a user for each username. As written, I think `profileimage…

				if (!$query) {
				throw new PhutilArgumentUsageException(
				pht(
				'"%s" is not a valid username.',
				$username));
				}
				$users[] = $query;
				}

				return $users;
				}


				}