Differential D17020 Diff 41522 src/applications/release/xaction/ReleaseChangeRequestTransactionType.php

Changeset View

Standalone View

				<?php

				abstract class ReleaseChangeRequestTransactionType
				extends PhabricatorModularTransactionType {

				public function getIcon() {
				return 'fa-compress';
				}

				// TODO either move down or up the hirarchy
				Lint: TODO Comment Inline Actions This comment has a TODO. Lint: TODO Comment: This comment has a TODO.
				// also, probably only works for string/phid types?
				// TODO There should be a way to get a good message from just
				Lint: TODO Comment Inline Actions This comment has a TODO. Lint: TODO Comment: This comment has a TODO.
				// "newRequiredError" and the edit engine.
				protected function validateRequiredFieldTransactions(
				$object,
				array $xactions,
				$field_name) {

				$errors = array();
				$old = $this->generateOldValue($object);

				if ($old === null && !$xactions) {
				$errors[] = $this->newRequiredError(pht('%s is required.', $field_name));
				}

				foreach ($xactions as $xaction) {
				$new = $xaction->getNewValue();
				if (!strlen($new)) {
				$errors[] = $this->newRequiredError(
				pht('%s is required.', $field_name));
				}
				}

				return $errors;
				}

				public function newChangeDetailView() {
				$viewer = $this->getViewer();

				$old = $this->getOldValue();
				$new = $this->getNewValue();

				$json = new PhutilJSON();

				return id(new PhabricatorApplicationTransactionTextDiffDetailView())
				->setViewer($viewer)
				->setOldText($old ? $json->encodeFormatted($old) : null)
				->setNewText($new ? $json->encodeFormatted($new) : null);
				}
				}