Differential D17004 Diff 41390 src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php
Changeset View
Changeset View
Standalone View
Standalone View
src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldRemarkup.php
| Show All 21 Lines | final class PhabricatorStandardCustomFieldRemarkup | ||||
| public function getApplicationTransactionRemarkupBlocks( | public function getApplicationTransactionRemarkupBlocks( | ||||
| PhabricatorApplicationTransaction $xaction) { | PhabricatorApplicationTransaction $xaction) { | ||||
| return array( | return array( | ||||
| $xaction->getNewValue(), | $xaction->getNewValue(), | ||||
| ); | ); | ||||
| } | } | ||||
| public function renderPropertyViewValue(array $handles) { | protected function renderValue() { | ||||
| $value = $this->getFieldValue(); | $value = $this->getFieldValue(); | ||||
| if (!strlen($value)) { | if (!strlen($value)) { | ||||
| return null; | return null; | ||||
| } | } | ||||
| // TODO: Once this stabilizes, it would be nice to let fields batch this. | // TODO: Once this stabilizes, it would be nice to let fields batch this. | ||||
| // For now, an extra query here and there on object detail pages isn't the | // For now, an extra query here and there on object detail pages isn't the | ||||
| // end of the world. | // end of the world. | ||||
avivey: Oh, using this on the list page might have a few more queries... | |||||
| $viewer = $this->getViewer(); | $viewer = $this->getViewer(); | ||||
| return new PHUIRemarkupView($viewer, $value); | return new PHUIRemarkupView($viewer, $value); | ||||
| } | } | ||||
| public function getApplicationTransactionTitle( | public function getApplicationTransactionTitle( | ||||
| PhabricatorApplicationTransaction $xaction) { | PhabricatorApplicationTransaction $xaction) { | ||||
| $author_phid = $xaction->getAuthorPHID(); | $author_phid = $xaction->getAuthorPHID(); | ||||
| ▲ Show 20 Lines • Show All 63 Lines • Show Last 20 Lines | |||||
Oh, using this on the list page might have a few more queries...