Differential D16533 Diff 39824 webroot/rsrc/js/application/conpherence/behavior-toggle-widget.js

Changeset View

Standalone View

webroot/rsrc/js/application/conpherence/behavior-toggle-widget.js

This file was added.

				/**
				* @provides javelin-behavior-toggle-widget
				* @requires javelin-behavior
				* javelin-dom
				* javelin-util
				* javelin-workflow
				* javelin-stratcom
				*/

				JX.behavior('toggle-widget', function(config) {

				function _toggleColumn(e) {
				e.kill();
				var node = JX.$('conpherence-main-layout');
				config.show = !config.show;
				JX.DOM.alterClass(node, 'hide-widgets', !config.show);

				epriestleyUnsubmitted Not Done Inline Actions Oh, sorry -- this one needs to be flipped. Seems to work correctly to me with this change to add an `!`: - JX.DOM.alterClass(node, 'hide-widgets', config.show); + JX.DOM.alterClass(node, 'hide-widgets', !config.show); epriestley: Oh, sorry -- //this// one needs to be flipped. Seems to work correctly to me with this change…
				new JX.Request(config.settingsURI)
				epriestleyUnsubmitted Not Done Inline Actions Instead of doing this classname test, just do: config.show = !config.show; JX.DOM.alterClass(node, 'hide-widgets', config.show); epriestley: Instead of doing this classname test, just do: ``` config.show = !config.show; JX.DOM.
				chadAuthorUnsubmitted Not Done Inline Actions having trouble with it taking two clicks to toggle the first load. I think thats why I did the check, to read it right off the node. chad: having trouble with it taking two clicks to toggle the first load. I think thats why I did the…
				.setData({value: (config.show ? 1 : 0)})
				.send();
				}
				epriestleyUnsubmitted Not Done Inline Actions As written, this does the wrong thing if you click twice (or any other even number of times), since we never change `config.show`. That is: Show column. Reload page: column visible. Click button twice: column hides, then visible again. Reload page. Expect: column visible. Actual: column hidden, because this button always saves "the state opposite the state that we had when the page was loaded" when clicked. epriestley: As written, this does the wrong thing if you click //twice// (or any other even number of…
				epriestleyUnsubmitted Not Done Inline Actions Does this need to be flipped, since you're flipping `config.show` before getting here? epriestley: Does this need to be flipped, since you're flipping `config.show` before getting here?
				chadAuthorUnsubmitted Not Done Inline Actions If I flip it, still takes two clicks to show or hide the column, however we send two setting requests so then it seems broken. chad: If I flip it, still takes two clicks to show or hide the column, however we send two setting…

				JX.Stratcom.listen(
				'click',
				'conpherence-widget-toggle',
				_toggleColumn);

				});