Differential D15743 Diff 37938 src/applications/files/worker/FileDeletionWorker.php

Changeset View

Standalone View

src/applications/files/worker/FileDeletionWorker.php

This file was added.

				<?php

				final class FileDeletionWorker extends PhabricatorWorker {

				private $file;

				epriestleyUnsubmitted Done Inline Actions I think this cache doesn't save us anything, and it's possible we might run into trouble with it if the same Worker is ever used to run multiple jobs. That is, it makes this code not work: $worker = new Worker(); $worker->setData('a'); $worker->execute(); $worker->setData('b'); $worker->execute(); Pretty sure we don't do that, and wouldn't really expect it to work, but maybe get rid of the cache since the best case is nothing and the worst case is a confusing surprise for someone a couple years from now. epriestley: I think this cache doesn't save us anything, and it's possible we might run into trouble with…
				private function loadFile() {
				if ($this->file) {
				return $this->file;
				}

				$id = idx($this->getTaskData(), 'fileID');
				if (!$id) {
				epriestleyUnsubmitted Done Inline Actions This is extremely minor, but consider using `filePHID` instead of `fileID` -- the major benefit is that it's a little easier to debug stuff because PHIDs can go into more tools (like `bin/remove destroy`, global search, etc). epriestley: This is extremely minor, but consider using `filePHID` instead of `fileID` -- the major benefit…
				throw new PhabricatorWorkerPermanentFailureException(
				pht('No "%s" in task data.', 'fileID'));
				}

				$file = id(new PhabricatorFileQuery())
				->setViewer(PhabricatorUser::getOmnipotentUser())
				->withIDs(array($id))
				->executeOne();

				if (!$file) {
				throw new PhabricatorWorkerPermanentFailureException(
				pht('File "%s" does not exist.', $id));
				}

				$this->file = $file;
				return $file;
				}

				public function doWork() {
				$file = $this->loadFile();
				$file->delete(); // Requiescat in pace
				}
				}