Changeset View
Changeset View
Standalone View
Standalone View
src/applications/maniphest/editor/ManiphestTransactionEditor.php
| Show First 20 Lines • Show All 194 Lines • ▼ Show 20 Lines | switch ($xaction->getTransactionType()) { | ||||
| $new_phids = idx($xaction->getNewValue(), 'columnPHIDs', array()); | $new_phids = idx($xaction->getNewValue(), 'columnPHIDs', array()); | ||||
| if (count($new_phids) !== 1) { | if (count($new_phids) !== 1) { | ||||
| throw new Exception( | throw new Exception( | ||||
| pht( | pht( | ||||
| "Expected exactly one '%s' in column transaction.", | "Expected exactly one '%s' in column transaction.", | ||||
| 'columnPHIDs')); | 'columnPHIDs')); | ||||
| } | } | ||||
| $columns = id(new PhabricatorProjectColumnQuery()) | |||||
| ->setViewer($this->requireActor()) | |||||
| ->withPHIDs($new_phids) | |||||
| ->execute(); | |||||
| $columns = mpull($columns, null, 'getPHID'); | |||||
| $positions = id(new PhabricatorProjectColumnPositionQuery()) | |||||
| ->setViewer($this->requireActor()) | |||||
| ->withObjectPHIDs(array($object->getPHID())) | |||||
| ->withBoardPHIDs(array($board_phid)) | |||||
| ->execute(); | |||||
| $before_phid = idx($xaction->getNewValue(), 'beforePHID'); | $before_phid = idx($xaction->getNewValue(), 'beforePHID'); | ||||
| $after_phid = idx($xaction->getNewValue(), 'afterPHID'); | $after_phid = idx($xaction->getNewValue(), 'afterPHID'); | ||||
| // throw new Exception( | |||||
| // print_r( | |||||
| // array( | |||||
| // 'before' => $before_phid, | |||||
| // 'after' => $after_phid, | |||||
| // 'old' => $old_phids, | |||||
| // 'new' => $new_phids, | |||||
| // ), true)); | |||||
| if (!$before_phid && !$after_phid && ($old_phids == $new_phids)) { | if (!$before_phid && !$after_phid && ($old_phids == $new_phids)) { | ||||
| // If we are not moving the object between columns and also not | // If we are not moving the object between columns and also not | ||||
| // reordering the position, this is a move on some other order | // reordering the position, this is a move on some other order | ||||
| // (like priority). We can leave the positions untouched and just | // (like priority). We can leave the positions untouched and just | ||||
| // bail, there's no work to be done. | // bail, there's no work to be done. | ||||
| return; | return; | ||||
| } | } | ||||
| // Otherwise, we're either moving between columns or adjusting the | // Otherwise, we're either moving between columns or adjusting the | ||||
| // object's position in the "natural" ordering, so we do need to update | // object's position in the "natural" ordering, so we do need to update | ||||
| // some rows. | // some rows. | ||||
| // Remove all existing column positions on the board. | $object_phid = $object->getPHID(); | ||||
| foreach ($positions as $position) { | |||||
| $position->delete(); | |||||
| } | |||||
| // Add the new column positions. | // We're doing layout with the ominpotent viewer to make sure we don't | ||||
| // remove positions in columns that exist, but which the actual actor | |||||
| foreach ($new_phids as $phid) { | // can't see. | ||||
| $column = idx($columns, $phid); | $omnipotent_viewer = PhabricatorUser::getOmnipotentUser(); | ||||
| if (!$column) { | |||||
| throw new Exception( | $board_tasks = id(new ManiphestTaskQuery()) | ||||
| pht('No such column "%s" exists!', $phid)); | ->setViewer($omnipotent_viewer) | ||||
| } | ->withEdgeLogicPHIDs( | ||||
| PhabricatorProjectObjectHasProjectEdgeType::EDGECONST, | |||||
| // Load the other object positions in the column. Note that we must | PhabricatorQueryConstraint::OPERATOR_AND, | ||||
| // skip implicit column creation to avoid generating a new position | array($board_phid)) | ||||
| // if the target column is a backlog column. | |||||
| $other_positions = id(new PhabricatorProjectColumnPositionQuery()) | |||||
| ->setViewer($this->requireActor()) | |||||
| ->withColumns(array($column)) | |||||
| ->withBoardPHIDs(array($board_phid)) | |||||
| ->setSkipImplicitCreate(true) | |||||
| ->execute(); | ->execute(); | ||||
| $other_positions = msort($other_positions, 'getOrderingKey'); | |||||
| // Set up the new position object. We're going to figure out the | $object_phids = mpull($board_tasks, 'getPHID'); | ||||
| // right sequence number and then persist this object with that | $object_phids[] = $object_phid; | ||||
| // sequence number. | |||||
| $new_position = id(new PhabricatorProjectColumnPosition()) | |||||
| ->setBoardPHID($board_phid) | |||||
| ->setColumnPHID($column->getPHID()) | |||||
| ->setObjectPHID($object->getPHID()); | |||||
| $updates = array(); | $engine = id(new PhabricatorBoardLayoutEngine()) | ||||
| $sequence = 0; | ->setViewer($omnipotent_viewer) | ||||
| ->setBoardPHIDs(array($board_phid)) | |||||
| // If we're just dropping this into the column without any specific | ->setObjectPHIDs($object_phids) | ||||
| // position information, put it at the top. | ->executeLayout(); | ||||
| if (!$before_phid && !$after_phid) { | |||||
| $new_position->setSequence($sequence)->save(); | // TODO: This logic needs to be revised if we legitimately support | ||||
Lint: TODO Comment: This comment has a TODO. | |||||
| $sequence++; | // multiple column positions. | ||||
| // NOTE: When a task is newly created, it's implicitly added to the | |||||
| // backlog but we don't currently record that in the "$old_phids". Just | |||||
| // clean it up for now. | |||||
| $columns = $engine->getObjectColumns($board_phid, $object_phid); | |||||
| foreach ($columns as $column) { | |||||
| $engine->queueRemovePosition( | |||||
| $board_phid, | |||||
| $column->getPHID(), | |||||
| $object_phid); | |||||
| } | } | ||||
| foreach ($other_positions as $position) { | // Remove all existing column positions on the board. | ||||
| $object_phid = $position->getObjectPHID(); | foreach ($old_phids as $column_phid) { | ||||
| $engine->queueRemovePosition( | |||||
| // If this is the object we're moving before and we haven't | $board_phid, | ||||
| // saved yet, insert here. | $column_phid, | ||||
| if (($before_phid == $object_phid) && !$new_position->getID()) { | $object_phid); | ||||
| $new_position->setSequence($sequence)->save(); | } | ||||
| $sequence++; | |||||
| } | // Add new positions. | ||||
| foreach ($new_phids as $column_phid) { | |||||
| // This object goes here in the sequence; we might need to update | if ($before_phid) { | ||||
| // the row. | $engine->queueAddPositionBefore( | ||||
| if ($sequence != $position->getSequence()) { | $board_phid, | ||||
| $updates[$position->getID()] = $sequence; | $column_phid, | ||||
| } | $object_phid, | ||||
| $sequence++; | $before_phid); | ||||
| } else if ($after_phid) { | |||||
| // If this is the object we're moving after and we haven't saved | $engine->queueAddPositionAfter( | ||||
| // yet, insert here. | $board_phid, | ||||
| if (($after_phid == $object_phid) && !$new_position->getID()) { | $column_phid, | ||||
| $new_position->setSequence($sequence)->save(); | $object_phid, | ||||
| $sequence++; | $after_phid); | ||||
| } | } else { | ||||
| $engine->queueAddPosition( | |||||
| $board_phid, | |||||
| $column_phid, | |||||
| $object_phid); | |||||
| } | } | ||||
| // We should have found a place to put it. | |||||
| if (!$new_position->getID()) { | |||||
| throw new Exception( | |||||
| pht('Unable to find a place to insert object on column!')); | |||||
| } | } | ||||
| // If we changed other objects' column positions, bulk reorder them. | $engine->applyPositionUpdates(); | ||||
| if ($updates) { | |||||
| $position = new PhabricatorProjectColumnPosition(); | |||||
| $conn_w = $position->establishConnection('w'); | |||||
| $pairs = array(); | |||||
| foreach ($updates as $id => $sequence) { | |||||
| // This is ugly because MySQL gets upset with us if it is | |||||
| // configured strictly and we attempt inserts which can't work. | |||||
| // We'll never actually do these inserts since they'll always | |||||
| // collide (triggering the ON DUPLICATE KEY logic), so we just | |||||
| // provide dummy values in order to get there. | |||||
| $pairs[] = qsprintf( | |||||
| $conn_w, | |||||
| '(%d, %d, "", "", "")', | |||||
| $id, | |||||
| $sequence); | |||||
| } | |||||
| queryfx( | |||||
| $conn_w, | |||||
| 'INSERT INTO %T (id, sequence, boardPHID, columnPHID, objectPHID) | |||||
| VALUES %Q ON DUPLICATE KEY UPDATE sequence = VALUES(sequence)', | |||||
| $position->getTableName(), | |||||
| implode(', ', $pairs)); | |||||
| } | |||||
| } | |||||
| break; | break; | ||||
| default: | default: | ||||
| break; | break; | ||||
| } | } | ||||
| } | } | ||||
| protected function applyFinalEffects( | protected function applyFinalEffects( | ||||
| PhabricatorLiskDAO $object, | PhabricatorLiskDAO $object, | ||||
| ▲ Show 20 Lines • Show All 640 Lines • Show Last 20 Lines | |||||
This comment has a TODO.