Differential D14672 Diff 35495 src/applications/transactions/editfield/PhabricatorPHIDListEditField.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/transactions/editfield/PhabricatorPHIDListEditField.php
| Show All 38 Lines | abstract class PhabricatorPHIDListEditField | ||||
| public function getIsSingleValue() { | public function getIsSingleValue() { | ||||
| return $this->isSingleValue; | return $this->isSingleValue; | ||||
| } | } | ||||
| protected function newHTTPParameterType() { | protected function newHTTPParameterType() { | ||||
| return new AphrontPHIDListHTTPParameterType(); | return new AphrontPHIDListHTTPParameterType(); | ||||
| } | } | ||||
| public function readValueFromComment($value) { | |||||
| // TODO: This is really hacky -- make sure we pass a plain PHID list to | |||||
| // the edit type. This method probably needs to move down to EditType, and | |||||
| // maybe more additional logic does too. | |||||
| $this->setUseEdgeTransactions(false); | |||||
| return parent::readValueFromComment($value); | |||||
| } | |||||
| public function getValueForTransaction() { | public function getValueForTransaction() { | ||||
| $new = parent::getValueForTransaction(); | $new = parent::getValueForTransaction(); | ||||
| if ($this->getIsSingleValue()) { | if ($this->getIsSingleValue()) { | ||||
| if ($new) { | if ($new) { | ||||
| return head($new); | return head($new); | ||||
| } else { | } else { | ||||
| return null; | return null; | ||||
| ▲ Show 20 Lines • Show All 86 Lines • Show Last 20 Lines | |||||