Differential D12198 Diff 35013 src/lint/linter/ArcanistESLintLinter.php

Changeset View

Standalone View

src/lint/linter/ArcanistESLintLinter.php

	<?php			<?php

	final class ArcanistESLintLinter extends ArcanistExternalLinter {			final class ArcanistESLintLinter extends ArcanistExternalLinter {

	public function getInfoName() {			public function getInfoName() {
	return 'ESLint';			return 'ESLint';
	}			}

	public function getInfoURI() {			public function getInfoURI() {
	return 'https://www.eslint.org';			return 'https://www.eslint.org';
	}			}

	public function getInfoDescription() {			public function getInfoDescription() {
	return pht('ESLint is a linter for JavaScript source files.');			return pht('ESLint is a linter for JavaScript source files.');
				michaeljs1990AuthorUnsubmitted Not Done Inline Actions This is the only way I see presently to set a min version. However as noted above the user can potential mess this up by setting a lower version in .arclint or .arcconfig and I have no way to stop this presently. michaeljs1990: This is the only way I see presently to set a min version. However as noted above the user can…
	}			}

	public function getVersion() {			public function getVersion() {
	$output = exec('eslint --version');			$output = exec('eslint --version');
				joshuaspenceUnsubmitted Done Inline Actions Linter names are typically uppercase, consider changing this to `ESLINT`. joshuaspence: Linter names are typically uppercase, consider changing this to `ESLINT`.

				aviveyUnsubmitted Not Done Inline Actions This was actually changed since - see T9353. The idea is that the one-liner output from `arc linters` should be useful for someone who never used eslint/javascript. avivey: This was actually changed since - see T9353. The idea is that the one-liner output from `arc…
	if (strpos($output, 'command not found') !== false) {			if (strpos($output, 'command not found') !== false) {
	return false;			return false;
	}			}

	return $output;			return $output;
	}			}

	public function getLinterName() {			public function getLinterName() {
	return 'ESLINT';			return 'ESLINT';
	}			}

				joshuaspenceUnsubmitted Done Inline Actions Technically this should be written as `pht('Install ESLint using` `%s`.', 'npm install -g eslint') because `npm install -g eslint` isn't really translatable. joshuaspence: Technically this should be written as `pht('Install ESLint using ```%s```.', 'npm install -g…
				bspoonUnsubmitted Not Done Inline Actions Hi! I tried using this linter, and configured it to use the eslint binary relative to my project (`node_modules/.bin/eslint`), and it wouldn't report the version (because I don't have eslint installed globally). Maybe the line should be this, instead? list($output) = execx('%C --version', $this->getExecutableCommand()); bspoon: Hi! I tried using this linter, and configured it to use the eslint binary relative to my…
				michaeljs1990AuthorUnsubmitted Not Done Inline Actions You are correct, sorry I missed that. Will push up a change for it shortly. michaeljs1990: You are correct, sorry I missed that. Will push up a change for it shortly.
	public function getLinterConfigurationName() {			public function getLinterConfigurationName() {
	return 'eslint';			return 'eslint';
	}			}

	public function getDefaultBinary() {			public function getDefaultBinary() {
				joshuaspenceUnsubmitted Done Inline Actions This is the default value, just remove this method. joshuaspence: This is the default value, just remove this method.
	return 'eslint';			return 'eslint';
	}			}

	public function getInstallInstructions() {			public function getInstallInstructions() {
	return pht('Install ESLint using `%s`.', 'npm install -g eslint');			return pht('Install ESLint using `%s`.', 'npm install -g eslint');
	}			}

	public function getMandatoryFlags() {			protected function getMandatoryFlags() {
	$options = array();			$options = array();

	$options[] = '--format=stylish';			$options[] = '--format=stylish';

	if ($this->eslintenv) {			if ($this->eslintenv) {
	$options[] = '--env='.$this->eslintenv;			$options[] = '--env='.$this->eslintenv;
	}			}

	▲ Show 20 Lines • Show All 73 Lines • Show Last 20 Lines