Differential D14266 Diff 34444 src/applications/drydock/worker/DrydockRepositoryOperationUpdateWorker.php

Changeset View

Standalone View

src/applications/drydock/worker/DrydockRepositoryOperationUpdateWorker.php

This file was added.

				<?php

				final class DrydockRepositoryOperationUpdateWorker
				extends DrydockWorker {

				protected function doWork() {
				$operation_phid = $this->getTaskDataValue('operationPHID');

				$hash = PhabricatorHash::digestForIndex($operation_phid);
				$lock_key = 'drydock.operation:'.$hash;

				$lock = PhabricatorGlobalLock::newLock($lock_key)
				->lock(1);

				try {
				$operation = $this->loadOperation($operation_phid);
				$this->handleUpdate($operation);
				} catch (Exception $ex) {
				$lock->unlock();
				throw $ex;
				}

				$lock->unlock();
				}


				private function handleUpdate(DrydockRepositoryOperation $operation) {
				$operation_state = $operation->getOperationState();

				switch ($operation_state) {
				case DrydockRepositoryOperation::STATE_WAIT:
				$operation
				->setOperationState(DrydockRepositoryOperation::STATE_WORK)
				->save();
				break;
				case DrydockRepositoryOperation::STATE_WORK:
				break;
				case DrydockRepositoryOperation::STATE_DONE:
				case DrydockRepositoryOperation::STATE_FAIL:
				// No more processing for these requests.
				return;
				}

				// TODO: We should probably check for other running operations with lower
				Lint: TODO Comment Inline Actions This comment has a TODO. Lint: TODO Comment: This comment has a TODO.
				// IDs and the same repository target and yield to them here? That is,
				// enforce sequential evaluation of operations against the same target so
				// that if you land "A" and then land "B", we always finish "A" first.
				// For now, just let stuff happen in any order. We can't lease until
				// we know we're good to move forward because we might deadlock if we do:
				// we're waiting for another operation to complete, and that operation is
				// waiting for a lease we're holding.

				try {
				$lease = $this->loadWorkingCopyLease($operation);

				epriestleyAuthorUnsubmitted Not Done Inline Actions As I think about it, this isn't necessarily true: we could have a limit of 1 working copy, with two merges in queue, and the second merge might lease it and then wait for the first operation indefinitely. I'll tweak the comment -- still fine conceptually, we'd just have to do the sequencing a little earlier. It normally costs ~1 second to grab a lease so we aren't losing much by not being aggressive about leasing. epriestley: As I think about it, this isn't necessarily true: we could have a limit of 1 working copy, with…
				$interface = $lease->getInterface(
				DrydockCommandInterface::INTERFACE_TYPE);

				// No matter what happens here, destroy the lease away once we're done.
				$lease->releaseOnDestruction(true);

				// TODO: Some day, do useful things instead of running `git show`.
				Lint: TODO Comment Inline Actions This comment has a TODO. Lint: TODO Comment: This comment has a TODO.
				list($stdout) = $interface->execx('git show');
				phlog($stdout);
				} catch (PhabricatorWorkerYieldException $ex) {
				throw $ex;
				} catch (Exception $ex) {
				$operation
				->setOperationState(DrydockRepositoryOperation::STATE_FAIL)
				->save();
				throw $ex;
				}

				$operation
				->setOperationState(DrydockRepositoryOperation::STATE_DONE)
				->save();

				// TODO: Once we have sequencing, we could awaken the next operation
				Lint: TODO Comment Inline Actions This comment has a TODO. Lint: TODO Comment: This comment has a TODO.
				// against this target after finishing or failing.
				}

				private function loadWorkingCopyLease(
				DrydockRepositoryOperation $operation) {
				$viewer = $this->getViewer();

				// TODO: This is very similar to leasing in Harbormaster, maybe we can
				Lint: TODO Comment Inline Actions This comment has a TODO. Lint: TODO Comment: This comment has a TODO.
				// share some of the logic?

				$lease_phid = $operation->getProperty('exec.leasePHID');
				if ($lease_phid) {
				$lease = id(new DrydockLeaseQuery())
				->setViewer($viewer)
				->withPHIDs(array($lease_phid))
				->executeOne();
				if (!$lease) {
				throw new PhabricatorWorkerPermanentFailureException(
				pht(
				'Lease "%s" could not be loaded.',
				$lease_phid));
				}
				} else {
				$working_copy_type = id(new DrydockWorkingCopyBlueprintImplementation())
				->getType();

				$repository = $operation->getRepository();

				$allowed_phids = $repository->getAutomationBlueprintPHIDs();
				$authorizing_phid = $repository->getPHID();

				$lease = DrydockLease::initializeNewLease()
				->setResourceType($working_copy_type)
				->setOwnerPHID($operation->getPHID())
				->setAuthorizingPHID($authorizing_phid)
				->setAllowedBlueprintPHIDs($allowed_phids);

				$map = $this->buildRepositoryMap($operation);

				$lease->setAttribute('repositories.map', $map);

				$task_id = $this->getCurrentWorkerTaskID();
				if ($task_id) {
				$lease->setAwakenTaskIDs(array($task_id));
				}

				$operation
				->setProperty('exec.leasePHID', $lease->getPHID())
				->save();

				$lease->queueForActivation();
				}

				if ($lease->isActivating()) {
				throw new PhabricatorWorkerYieldException(15);
				}

				if (!$lease->isActive()) {
				throw new PhabricatorWorkerPermanentFailureException(
				pht(
				'Lease "%s" never activated.',
				$lease->getPHID()));
				}

				return $lease;
				}

				private function buildRepositoryMap(DrydockRepositoryOperation $operation) {
				$repository = $operation->getRepository();

				$target = $operation->getRepositoryTarget();
				list($type, $name) = explode(':', $target, 2);
				switch ($type) {
				case 'branch':
				$spec = array(
				'branch' => $name,
				);
				break;
				default:
				throw new Exception(
				pht(
				'Unknown repository operation target type "%s" (in target "%s").',
				$type,
				$target));
				}

				$map = array();
				$map[$repository->getCloneName()] = array(
				'phid' => $repository->getPHID(),
				'default' => true,
				) + $spec;

				return $map;
				}
				}