Differential D13589 Diff 33531 src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php
<?php | <?php | ||||
abstract class PhabricatorDaemonManagementWorkflow | abstract class PhabricatorDaemonManagementWorkflow | ||||
extends PhabricatorManagementWorkflow { | extends PhabricatorManagementWorkflow { | ||||
private $runDaemonsAsUser = null; | private $runDaemonsAsUser = null; | ||||
final protected function loadAvailableDaemonClasses() { | final protected function loadAvailableDaemonClasses() { | ||||
$loader = new PhutilSymbolLoader(); | return id(new PhutilSymbolLoader()) | ||||
return $loader | |||||
->setAncestorClass('PhutilDaemon') | ->setAncestorClass('PhutilDaemon') | ||||
->setConcreteOnly(true) | ->setConcreteOnly(true) | ||||
->selectSymbolsWithoutLoading(); | ->selectSymbolsWithoutLoading(); | ||||
epriestley: I'd expect that this previously loaded a list of symbol dictionaries, and now loads a map of… | |||||
} | } | ||||
final protected function getPIDDirectory() { | final protected function getPIDDirectory() { | ||||
$path = PhabricatorEnv::getEnvConfig('phd.pid-directory'); | $path = PhabricatorEnv::getEnvConfig('phd.pid-directory'); | ||||
return $this->getControlDirectory($path); | return $this->getControlDirectory($path); | ||||
} | } | ||||
final protected function getLogDirectory() { | final protected function getLogDirectory() { | ||||
▲ Show 20 Lines • Show All 658 Lines • Show Last 20 Lines |
I'd expect that this previously loaded a list of symbol dictionaries, and now loads a map of objects. Callers likely need changes to swap newv($symbol['name'], array()) out or whatever.