Changeset View
Changeset View
Standalone View
Standalone View
src/applications/badges/query/PhabricatorBadgesQuery.php
- This file was added.
<?php | |||||
final class PhabricatorBadgesQuery | |||||
extends PhabricatorCursorPagedPolicyAwareQuery { | |||||
private $ids; | |||||
private $phids; | |||||
private $qualities; | |||||
private $statuses; | |||||
private $recipientPHIDs; | |||||
private $needRecipients; | |||||
public function withIDs(array $ids) { | |||||
$this->ids = $ids; | |||||
return $this; | |||||
} | |||||
public function withPHIDs(array $phids) { | |||||
$this->phids = $phids; | |||||
return $this; | |||||
} | |||||
chad: hehehe | |||||
public function withQualities(array $qualities) { | |||||
$this->qualities = $qualities; | |||||
return $this; | |||||
} | |||||
public function withStatuses(array $statuses) { | |||||
$this->statuses = $statuses; | |||||
return $this; | |||||
} | |||||
public function withRecipientPHIDs(array $recipient_phids) { | |||||
$this->recipientPHIDs = $recipient_phids; | |||||
return $this; | |||||
} | |||||
public function needRecipients($need_recipients) { | |||||
$this->needRecipients = $need_recipients; | |||||
return $this; | |||||
} | |||||
protected function loadPage() { | |||||
return $this->loadStandardPage($this->newResultObject()); | |||||
} | |||||
public function newResultObject() { | |||||
return new PhabricatorBadgesBadge(); | |||||
} | |||||
protected function didFilterPage(array $badges) { | |||||
if ($this->needRecipients) { | |||||
$edge_query = id(new PhabricatorEdgeQuery()) | |||||
->withSourcePHIDs(mpull($badges, 'getPHID')) | |||||
->withEdgeTypes( | |||||
Done Inline ActionsThis should be simplified to: return $this->loadStandardPage($this->newResultObject()); Then implement newResultObject() (as return new PhabricatorBadge();). epriestley: This should be simplified to:
return $this->loadStandardPage($this->newResultObject())… | |||||
array( | |||||
Done Inline ActionsUnused. epriestley: Unused. | |||||
PhabricatorBadgeHasRecipientEdgeType::EDGECONST, | |||||
)); | |||||
$edge_query->execute(); | |||||
foreach ($badges as $badge) { | |||||
$phids = $edge_query->getDestinationPHIDs( | |||||
array( | |||||
$badge->getPHID(), | |||||
)); | |||||
$badge->attachRecipientPHIDs($phids); | |||||
} | |||||
} | |||||
return $badges; | |||||
} | |||||
Done Inline ActionsThis is fine as written, but could possibly be simplified a bit with getDestinationPHIDs() on the EdgeQuery. epriestley: This is fine as written, but could possibly be simplified a bit with `getDestinationPHIDs()` on… | |||||
protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) { | |||||
$where = parent::buildWhereClauseParts($conn); | |||||
Done Inline ActionsThis load+attach stuff should happen in didFilterPage(), so we don't need to load data for objects we're going to throw away a second later when we do policy filtering. This should also only happen if needRecipients() is set. Otherwise, we'll load all these edges every time, which might be a huge amount of data if there are some very common badges with thousands of recipients. epriestley: This load+attach stuff should happen in `didFilterPage()`, so we don't need to load data for… | |||||
if ($this->ids !== null) { | |||||
$where[] = qsprintf( | |||||
$conn, | |||||
'id IN (%Ld)', | |||||
$this->ids); | |||||
} | |||||
if ($this->phids !== null) { | |||||
Done Inline ActionsThis can be simplified slightly by implementing buildWhereClauseParts() instead, in modern code. epriestley: This can be simplified slightly by implementing `buildWhereClauseParts()` instead, in modern… | |||||
$where[] = qsprintf( | |||||
$conn, | |||||
'phid IN (%Ls)', | |||||
$this->phids); | |||||
} | |||||
if ($this->qualities !== null) { | |||||
$where[] = qsprintf( | |||||
$conn, | |||||
'quality IN (%Ls)', | |||||
$this->qualities); | |||||
} | |||||
if ($this->statuses !== null) { | |||||
$where[] = qsprintf( | |||||
$conn, | |||||
'status IN (%Ls)', | |||||
$this->statuses); | |||||
} | |||||
return $where; | |||||
} | |||||
public function getQueryApplicationClass() { | |||||
return 'PhabricatorBadgesApplication'; | |||||
} | |||||
} |
hehehe