Differential D13356 Diff 32343 src/applications/harbormaster/controller/HarbormasterPlanViewController.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/harbormaster/controller/HarbormasterPlanViewController.php
Show All 21 Lines | if (!$plan) { | ||||
return new Aphront404Response(); | return new Aphront404Response(); | ||||
} | } | ||||
$timeline = $this->buildTransactionTimeline( | $timeline = $this->buildTransactionTimeline( | ||||
$plan, | $plan, | ||||
new HarbormasterBuildPlanTransactionQuery()); | new HarbormasterBuildPlanTransactionQuery()); | ||||
$timeline->setShouldTerminate(true); | $timeline->setShouldTerminate(true); | ||||
$title = pht('Plan %d', $id); | $title = $plan->getName(); | ||||
epriestley: Maybe throw the name in here, too? | |||||
$header = id(new PHUIHeaderView()) | $header = id(new PHUIHeaderView()) | ||||
->setHeader($title) | ->setHeader($plan->getName()) | ||||
->setUser($viewer) | ->setUser($viewer) | ||||
->setPolicyObject($plan); | ->setPolicyObject($plan); | ||||
$box = id(new PHUIObjectBoxView()) | $box = id(new PHUIObjectBoxView()) | ||||
->setHeader($header); | ->setHeader($header); | ||||
$actions = $this->buildActionList($plan); | $actions = $this->buildActionList($plan); | ||||
$this->buildPropertyLists($box, $plan, $actions); | $this->buildPropertyLists($box, $plan, $actions); | ||||
$crumbs = $this->buildApplicationCrumbs(); | $crumbs = $this->buildApplicationCrumbs(); | ||||
$crumbs->addTextCrumb(pht('Plan %d', $id)); | $crumbs->addTextCrumb(pht('Plan %d', $id)); | ||||
Not Done Inline ActionsThis one is fine as-is (short for crumbs). epriestley: This one is fine as-is (short for crumbs). | |||||
list($step_list, $has_any_conflicts, $would_deadlock) = | list($step_list, $has_any_conflicts, $would_deadlock) = | ||||
$this->buildStepList($plan); | $this->buildStepList($plan); | ||||
if ($would_deadlock) { | if ($would_deadlock) { | ||||
$box->setFormErrors( | $box->setFormErrors( | ||||
array( | array( | ||||
pht( | pht( | ||||
▲ Show 20 Lines • Show All 423 Lines • Show Last 20 Lines |
Maybe throw the name in here, too?