Page MenuHomePhabricator
Differential D13091 Diff 32217 src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Changeset View

Standalone View

View Options

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Show First 20 Lines • Show All 1,118 Lines • ▼ Show 20 Lines '%s edited question(s), added %s: %s; removed %s: %s.' =>
'%s removed owners: %3$s.', '%s removed owners: %3$s.',
), ),
), ),
'%s changed %s package owner(s), added %s: %s; removed %s: %s.' => array( '%s changed %s package owner(s), added %s: %s; removed %s: %s.' => array(
'%s changed package owners, added: %4$s; removed: %6$s.', '%s changed package owners, added: %4$s; removed: %6$s.',
), ),
'Found %s book(s).' => array(
'Found %s book.',
epriestleyUnsubmitted
Done
Inline Actions

Omit one level of array() to fix 1 books.

epriestley: Omit one level of `array()` to fix `1 books`.
'Found %s books.',
),
'Found %s file(s) in project.' => array(
'Found %s file in project.',
'Found %s files in project.',
),
epriestleyUnsubmitted
Done
Inline Actions

Omit 1 level of array(), etc, etc.

epriestley: Omit 1 level of array(), etc, etc.
'Found %s unatomized, uncached file(s).' => array(
'Found %s unatomized, uncached file.',
'Found %s unatomized, uncached files.',
),
'Found %s file(s) to atomize.' => array(
'Found %s file to atomize.',
'Found %s files to atomize.',
),
'Atomizing %s file(s).' => array(
'Atomizing %s file.',
'Atomizing %s files.',
),
'Creating %s document(s).' => array(
'Creating %s document.',
'Creating %s documents.',
),
'Deleting %s document(s).' => array(
'Deleting %s document.',
'Deleting %s documents.',
),
'Found %s obsolete atom(s) in graph.' => array(
'Found %s obsolete atom in graph.',
'Found %s obsolete atoms in graph.',
),
'Found %s new atom(s) in graph.' => array(
'Found %s new atom in graph.',
'Found %s new atoms in graph.',
),
'This call takes %s parameter(s), but only %s are documented.' => array(
array(
'This call takes %s parameter, but only %s is documented.',
'This call takes %s parameter, but only %s are documented.',
),
array(
'This call takes %s parameters, but only %s is documented.',
'This call takes %s parameters, but only %s are documented.',
),
),
); );
} }
} }
joshuaspenceAuthorUnsubmitted
Done
Inline Actions

Not sure if this is possible, but the if second parameter is singular then this should read "... but only %s is documented".

joshuaspence: Not sure if this is possible, but the if second parameter is singular then this should read "...
epriestleyUnsubmitted
Done
Inline Actions

Broadly, each level of array() depth corresponds to a parameter. So if you have no parameters, you have no arrays:

'apple' => 'le appelo',

If you have one parameter, you should have maximum depth of one array:

'%s apple(s)' => array(
  'an apple',
  'apples',
)

(Not two arrays, as some of the cases above do.)

If you have two parameters, you'll have a depth of two arrays, and the inner arrays will handle the second parameter:

'%s apple(s) and %s banana(s)' => array(
  array(...), // Cases with 1 apple
  array(...), // Cases with some other number of apples
);

So I'd expect these to produce the correct behavior -- one conversion, maximum depth is one array:

'You have %s apple(s).' => array(
  'You have an apple.',
  'You have %s apples.',
);

Two conversions, maximum depth is two arrays:

'You have %s apple(s) and %s banana(s).' => array(
  array(
    'You have an apple and a banana.',
    'You have an apples and %2$s bananas.',
  ),
  array(
    'You have %s apples and a banana.',
    'You have %s apples and %s bananas.',
  ),
);
epriestley: Broadly, each level of `array()` depth corresponds to a parameter. So if you have no parameters…
Phabricator · Built by Phacility