Changeset View
Changeset View
Standalone View
Standalone View
src/lint/engine/ArcanistLintEngine.php
| Show First 20 Lines • Show All 325 Lines • ▼ Show 20 Lines | abstract class ArcanistLintEngine { | ||||
| final private function isRelevantMessage(ArcanistLintMessage $message) { | final private function isRelevantMessage(ArcanistLintMessage $message) { | ||||
| // When a user runs "arc lint", we default to raising only warnings on | // When a user runs "arc lint", we default to raising only warnings on | ||||
| // lines they have changed (errors are still raised anywhere in the | // lines they have changed (errors are still raised anywhere in the | ||||
| // file). The list of $changed lines may be null, to indicate that the | // file). The list of $changed lines may be null, to indicate that the | ||||
| // path is a directory or a binary file so we should not exclude | // path is a directory or a binary file so we should not exclude | ||||
| // warnings. | // warnings. | ||||
| if (!$this->changedLines || | if (!$this->changedLines || $message->isError()) { | ||||
| $message->isError() || | |||||
| $message->shouldBypassChangedLineFiltering()) { | |||||
| return true; | return true; | ||||
| } | } | ||||
| $locations = $message->getOtherLocations(); | $locations = $message->getOtherLocations(); | ||||
| $locations[] = $message->toDictionary(); | $locations[] = $message->toDictionary(); | ||||
| foreach ($locations as $location) { | foreach ($locations as $location) { | ||||
| $path = idx($location, 'path', $message->getPath()); | $path = idx($location, 'path', $message->getPath()); | ||||
| ▲ Show 20 Lines • Show All 268 Lines • Show Last 20 Lines | |||||