Differential D13036 Diff 31560 src/applications/diffusion/symbol/DiffusionExternalSymbolsSource.php

Changeset View

Standalone View

				<?php

				abstract class DiffusionExternalSymbolsSource {

				epriestleyUnsubmitted Not Done Inline Actions You could also just put these methods on `DiffusionExternalSymbolQuery` and have the sources subclass that, although I'm not really sure if that's cleaner/simpler. This design feels about equally good to me. epriestley: You could also just put these methods on `DiffusionExternalSymbolQuery` and have the sources…
				/**
				aviveyAuthorUnsubmitted Not Done Inline Actions I'd rather keep `Query` separate from the `Source`/`Engine`. avivey: I'd rather keep `Query` separate from the `Source`/`Engine`.
				* @return list of PhabricatorRepositorySymbol
				*/
				abstract public function executeQuery(DiffusionExternalSymbolQuery $query);

				epriestleyUnsubmitted Done Inline Actions Maybe "lookupSymbols" since we return a list of matches now. Or `executeQuery()`? epriestley: Maybe "lookupSymbols" since we return a list of matches now. Or `executeQuery()`?
				protected function buildExternalSymbol() {
				aviveyAuthorUnsubmitted Not Done Inline Actions `executeQuery` sounds good. avivey: `executeQuery` sounds good.
				return id(new PhabricatorRepositorySymbol())
				->setIsExternal(true)
				->makeEphemeral();
				}
				}
				aviveyAuthorUnsubmitted Not Done Inline Actions I'll replace this with protected function buildExternalSymbol() { return id(new PhabricatorRepositorySymbol()) ->setIsExternal(true) ->makeEphemeral(); } avivey: I'll replace this with ```lang=php protected function buildExternalSymbol() { return id(new…