Differential D12946 Diff 31236 src/applications/diffusion/controller/DiffusionBrowseFileController.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/diffusion/controller/DiffusionBrowseFileController.php
Show First 20 Lines • Show All 261 Lines • ▼ Show 20 Lines | if (!$show_color) { | ||||
if ($this->getRequest()->isAjax()) { | if ($this->getRequest()->isAjax()) { | ||||
return $corpus_table; | return $corpus_table; | ||||
} | } | ||||
$id = celerity_generate_unique_node_id(); | $id = celerity_generate_unique_node_id(); | ||||
$repo = $drequest->getRepository(); | $repo = $drequest->getRepository(); | ||||
$symbol_repos = $repo->getSymbolSources(); | $symbol_repos = nonempty($repo->getSymbolSources(), array()); | ||||
$symbol_repos[] = $repo; | $symbol_repos[] = $repo; | ||||
$lang = last(explode('.', $drequest->getPath())); | $lang = last(explode('.', $drequest->getPath())); | ||||
$repo_languages = $repo->getSymbolLanguages(); | $repo_languages = $repo->getSymbolLanguages(); | ||||
$repo_languages = nonempty($repo_languages, array()); | |||||
$repo_languages = array_fill_keys($repo_languages, true); | $repo_languages = array_fill_keys($repo_languages, true); | ||||
if (empty($repo_languages) || isset($repo_languages[$lang])) { | |||||
$needs_symbols = true; | |||||
if ($repo_languages && $symbol_repos) { | |||||
epriestley: When testing arrays for emptiness, prefer `if ($x)` over `if (empty($x))` for consistency and… | |||||
$have_symbols = id(new DiffusionSymbolQuery()) | |||||
->existsSymbolsInRepository($repo->getPHID()); | |||||
if (!$have_symbols) { | |||||
$needs_symbols = false; | |||||
} | |||||
} | |||||
Done Inline ActionsDebugging var_dump(). epriestley: Debugging `var_dump()`. | |||||
if ($needs_symbols && $repo_languages) { | |||||
$needs_symbols = isset($repo_languages[$lang]); | |||||
} | |||||
if ($needs_symbols) { | |||||
Javelin::initBehavior( | Javelin::initBehavior( | ||||
'repository-crossreference', | 'repository-crossreference', | ||||
array( | array( | ||||
'container' => $id, | 'container' => $id, | ||||
'lang' => $lang, | 'lang' => $lang, | ||||
'repositories' => $symbol_repos, | 'repositories' => $symbol_repos, | ||||
)); | )); | ||||
} | } | ||||
▲ Show 20 Lines • Show All 800 Lines • Show Last 20 Lines |
When testing arrays for emptiness, prefer if ($x) over if (empty($x)) for consistency and simplicity.