Differential D12696 Diff 30534 src/lint/linter/ArcanistClosureLinter.php

Changeset View

Standalone View

Show All 31 Lines	final class ArcanistClosureLinter extends ArcanistExternalLinter {
public function getInstallInstructions() {		public function getInstallInstructions() {
return pht(		return pht(
'Install %s using `%s`.',		'Install %s using `%s`.',
'gjslint',		'gjslint',
'sudo easy_install http://closure-linter.googlecode.com/'.		'sudo easy_install http://closure-linter.googlecode.com/'.
'files/closure_linter-latest.tar.gz');		'files/closure_linter-latest.tar.gz');
}		}

public function supportsReadDataFromStdin() {
return false;
}

protected function parseLinterOutput($path, $err, $stdout, $stderr) {		protected function parseLinterOutput($path, $err, $stdout, $stderr) {
$lines = phutil_split_lines($stdout, false);		$lines = phutil_split_lines($stdout, false);
$messages = array();		$messages = array();

foreach ($lines as $line) {		foreach ($lines as $line) {
$matches = null;		$matches = null;
if (!preg_match('/^Line (\d+), E:(\d+): (.*)/', $line, $matches)) {		if (!preg_match('/^Line (\d+), E:(\d+): (.*)/', $line, $matches)) {
continue;		continue;
Show All 15 Lines