Differential D12619 Diff 30301 src/applications/calendar/controller/PhabricatorCalendarEventEditController.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/calendar/controller/PhabricatorCalendarEventEditController.php
| Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Lines | if ($this->isCreate()) { | ||||
| $start_time->setValue($event->getDateFrom()); | $start_time->setValue($event->getDateFrom()); | ||||
| $submit_label = pht('Update'); | $submit_label = pht('Update'); | ||||
| $filter = 'event/edit/'.$event->getID().'/'; | $filter = 'event/edit/'.$event->getID().'/'; | ||||
| $page_title = pht('Update Event'); | $page_title = pht('Update Event'); | ||||
| $redirect = 'updated'; | $redirect = 'updated'; | ||||
| $subscribers = PhabricatorSubscribersQuery::loadSubscribersForPHID( | $subscribers = PhabricatorSubscribersQuery::loadSubscribersForPHID( | ||||
| $event->getPHID()); | $event->getPHID()); | ||||
| $invitees = array(); | $invitees = array(); | ||||
| foreach ($event->getInvitees() as $invitee) { | foreach ($event->getInvitees() as $invitee) { | ||||
| if ($invitee->isUninvited()) { | if ($invitee->isUninvited()) { | ||||
| continue; | continue; | ||||
| } else { | } else { | ||||
| $invitees[] = $invitee->getInviteePHID(); | $invitees[] = $invitee->getInviteePHID(); | ||||
| } | } | ||||
| } | } | ||||
| } | } | ||||
| $errors = array(); | $errors = array(); | ||||
| if ($request->isFormPost()) { | if ($request->isFormPost()) { | ||||
| $xactions = array(); | $xactions = array(); | ||||
| $name = $request->getStr('name'); | $name = $request->getStr('name'); | ||||
| $type = $request->getInt('status'); | $type = $request->getInt('status'); | ||||
| $start_value = $start_time->readValueFromRequest($request); | $start_value = $start_time->readValueFromRequest($request); | ||||
| $end_value = $end_time->readValueFromRequest($request); | $end_value = $end_time->readValueFromRequest($request); | ||||
| $description = $request->getStr('description'); | $description = $request->getStr('description'); | ||||
| $subscribers = $request->getArr('subscribers'); | $subscribers = $request->getArr('subscribers'); | ||||
| $invitees = $request->getArr('invitees'); | $invitees = $request->getArr('invitees'); | ||||
| $new_invitees = $this->getNewInviteeList($invitees, $event); | $new_invitees = $this->getNewInviteeList($invitees, $event); | ||||
| $status_attending = PhabricatorCalendarEventInvitee::STATUS_ATTENDING; | |||||
| if ($this->isCreate()) { | if ($this->isCreate()) { | ||||
| $status = idx($new_invitees, $user->getPHID()); | $status = idx($new_invitees, $user->getPHID()); | ||||
| $status_attending = PhabricatorCalendarEventInvitee::STATUS_ATTENDING; | |||||
| if ($status) { | if ($status) { | ||||
| $new_invitees[$user->getPHID()] = $status_attending; | $new_invitees[$user->getPHID()] = $status_attending; | ||||
| } | } | ||||
| } | } | ||||
| if ($start_time->getError()) { | if ($start_time->getError()) { | ||||
| $errors[] = pht('Invalid start time; reset to default.'); | $errors[] = pht('Invalid start time; reset to default.'); | ||||
| } | } | ||||
| ▲ Show 20 Lines • Show All 150 Lines • ▼ Show 20 Lines | public function getNewInviteeList(array $phids, $event) { | ||||
| $invitees = $event->getInvitees(); | $invitees = $event->getInvitees(); | ||||
| $invitees = mpull($invitees, null, 'getInviteePHID'); | $invitees = mpull($invitees, null, 'getInviteePHID'); | ||||
| $invited_status = PhabricatorCalendarEventInvitee::STATUS_INVITED; | $invited_status = PhabricatorCalendarEventInvitee::STATUS_INVITED; | ||||
| $uninvited_status = PhabricatorCalendarEventInvitee::STATUS_UNINVITED; | $uninvited_status = PhabricatorCalendarEventInvitee::STATUS_UNINVITED; | ||||
| $phids = array_fuse($phids); | $phids = array_fuse($phids); | ||||
| $new = array(); | $new = array(); | ||||
| foreach ($phids as $phid) { | foreach ($phids as $phid) { | ||||
| $old_invitee = idx($invitees, $phid); | $old_status = $event->getUserInviteStatus($phid); | ||||
| if ($old_invitee) { | |||||
| $old_status = $old_invitee->getStatus(); | |||||
| if ($old_status != $uninvited_status) { | if ($old_status != $uninvited_status) { | ||||
| continue; | continue; | ||||
| } | } | ||||
| } | |||||
| $new[$phid] = $invited_status; | $new[$phid] = $invited_status; | ||||
epriestley: For consistency, write this as:
if (condition) {
continue;
}
(That is, on three… | |||||
| } | } | ||||
| foreach ($invitees as $invitee) { | foreach ($invitees as $invitee) { | ||||
| $deleted_invitee = !idx($phids, $invitee->getInviteePHID()); | $deleted_invitee = !idx($phids, $invitee->getInviteePHID()); | ||||
| if ($deleted_invitee) { | if ($deleted_invitee) { | ||||
| $new[$invitee->getInviteePHID()] = $uninvited_status; | $new[$invitee->getInviteePHID()] = $uninvited_status; | ||||
| } | } | ||||
| } | } | ||||
| return $new; | return $new; | ||||
| } | } | ||||
| } | } | ||||
For consistency, write this as:
if (condition) { continue; }(That is, on three separate lines.)