Differential D11438 Diff 27511 src/infrastructure/daemon/workers/management/PhabricatorWorkerTriggerManagementWorkflow.php

Changeset View

Standalone View

View Options

src/infrastructure/daemon/workers/management/PhabricatorWorkerTriggerManagementWorkflow.php

This file was added.

				<?php

				abstract class PhabricatorWorkerTriggerManagementWorkflow
				extends PhabricatorManagementWorkflow {

				protected function getTriggerSelectionArguments() {
				return array(
				array(
				'name' => 'id',
				'param' => 'id',
				'repeat' => true,
				'help' => pht('Select one or more triggers by ID.'),
				),
				);
				}

				protected function loadTriggers(PhutilArgumentParser $args) {
				$ids = $args->getArg('id');
				if (!$ids) {
				throw new PhutilArgumentUsageException(
				pht('Use --id to select triggers by ID.'));
				}

				$triggers = id(new PhabricatorWorkerTriggerQuery())
				->withIDs($ids)
				->needEvents(true)
				->execute();
				$triggers = mpull($triggers, null, 'getID');

				foreach ($ids as $id) {
				if (empty($triggers[$id])) {
				throw new PhutilArgumentUsageException(
				pht('No trigger exists with id "%s"!', $id));
				}
				}

				return $triggers;
				}

				protected function describeTrigger(PhabricatorWorkerTrigger $trigger) {
				return pht('Trigger %d', $trigger->getID());
				}

				protected function parseTime($time) {
				if (!strlen($time)) {
				return null;
				}

				$epoch = strtotime($time);
				if ($epoch <= 0) {
				throw new PhutilArgumentUsageException(
				pht('Unable to parse time "%s".', $time));
				}
				return $epoch;
				}

				btrahanUnsubmitted Not Done Inline Actions Maybe you want to use the fancy phutil time stuff? I tend to get tripped up on any "time" parameter in CLI tools. btrahan: Maybe you want to use the fancy phutil time stuff? I tend to get tripped up on any "time"…
				epriestleyAuthorUnsubmitted Not Done Inline Actions Yeah, the time locale stuff can get murky pretty quickly. The fancy phutil time stuff takes a viewer and we don't have a real viewer (specifically, we don't have a viewer with meaningful timezone preferences), which is why I'm not using it. Possibly I should and just pass a fake viewer. Generally, my "solution" for time stuff is to print the time out after we parse it so you can see what we ended up with, although `phabricator_datetime()` doesn't include timezone information so this might be limited in effect. A better approach might be to use some CLI date printing function which picks a longer-form, explicit-timezone format like "YYYY-MM-DD HH:MM:SS ZZZ". The actual behavior of this parameter and the printed times is to use the server's configured default timezone. If you set it to "America/Los_Angeles", you should be able to input times in local notation and get local outputs out. This is the same behavior you'd get by using the other parsing stuff with a fake/omnipotent viewer. However, in the Phacility cluster, the timezone is UTC, so `bin/trigger fire --now X` can mean something different on your local machine vs in the cluster. If this ends up being confusing, we could change the parsing to support or require an explicit timezone, e.g. `bin/trigger fire --timezone America/Los_Angeles --now X`, although that's pretty cumbersome. In all cases, you can specify dates and times in long form with a timezone to get unambiguous parses, although obviously that's also cumbersome. You can also figure out an epoch timestamp and use it with `@timestamp` notation if that's easier (e.g., if you have an epoch value from a database or something, you can just put @ on the front and copy-paste it, without needing to convert to a human-readable time). For now, let's just keep an eye on it and see how confusing it is? We might end up not needing to interact with it from the CLI very much. If it sucks, we can just ramp up the explicitness of timezones until it feels like we're in a good place on the safety checks. epriestley: Yeah, the time locale stuff can get murky pretty quickly. The fancy phutil time stuff takes a…
				}