Differential D11050 Diff 26716 src/applications/diffusion/application/PhabricatorDiffusionApplication.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/diffusion/application/PhabricatorDiffusionApplication.php
Show All 34 Lines | final class PhabricatorDiffusionApplication extends PhabricatorApplication { | ||||
public function getEventListeners() { | public function getEventListeners() { | ||||
return array( | return array( | ||||
new DiffusionHovercardEventListener(), | new DiffusionHovercardEventListener(), | ||||
); | ); | ||||
} | } | ||||
public function getRemarkupRules() { | public function getRemarkupRules() { | ||||
return array( | return array( | ||||
new DiffusionRepositoryRemarkupRule(), | |||||
new DiffusionCommitRemarkupRule(), | new DiffusionCommitRemarkupRule(), | ||||
new DiffusionRepositoryRemarkupRule(), | |||||
fabe: This somehow only works when inserted at the end of this array.
I was unable to do this with… | |||||
Not Done Inline ActionsHmm, I'm surprised that these are order-dependent. Using two separate rules seems reasonable to me, though. Let me poke around at this locally... epriestley: Hmm, I'm surprised that these are order-dependent. Using two separate rules seems reasonable to… | |||||
new DiffusionRepositoryByIDRemarkupRule(), | |||||
); | ); | ||||
} | } | ||||
public function getRoutes() { | public function getRoutes() { | ||||
return array( | return array( | ||||
'/r(?P<callsign>[A-Z]+)(?P<commit>[a-z0-9]+)' | '/r(?P<callsign>[A-Z]+)(?P<commit>[a-z0-9]+)' | ||||
=> 'DiffusionCommitController', | => 'DiffusionCommitController', | ||||
'/diffusion/' => array( | '/diffusion/' => array( | ||||
▲ Show 20 Lines • Show All 93 Lines • Show Last 20 Lines |
This somehow only works when inserted at the end of this array.
I was unable to do this with only one remarkup rule and i've got no idea why this now works when placed here.
Are remarkup rules applied here when another one already matched?