Differential D11074 Diff 26680 src/applications/differential/edge/DifferentialReviewerForRevisionEdgeType.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/differential/edge/DifferentialReviewerForRevisionEdgeType.php
- This file was added.
<?php | |||||
final class DifferentialReviewerForRevisionEdgeType | |||||
extends PhabricatorEdgeType { | |||||
const EDGECONST = 36; | |||||
public function getInverseEdgeConstant() { | |||||
return DifferentialRevisionHasReviewerEdgeType::EDGECONST; | |||||
} | |||||
public function shouldWriteInverseTransactions() { | |||||
return true; | |||||
} | |||||
} | |||||
epriestley: We should probably remove this -- it's not normally possible to introduce a cycle for this edge… | |||||
Not Done Inline ActionsRemove this for all edges or just for DifferentialReviewerForRevisionEdgeType? Also, is DifferentialReviewer correct? I was also considering PeopleReviewer or something. joshuaspence: Remove this for all edges or just for `DifferentialReviewerForRevisionEdgeType`? Also, is… |
We should probably remove this -- it's not normally possible to introduce a cycle for this edge type (or most types of edges), and we pay a not-totally-trivial performance cost to do cycle detect on every write if it's enabled.
The "Task depends on task" edge from the original reference diff was a rare case where cycle detection is of particular importance, since it's easy to introduce a cycle from the UI with that edge type.