Differential D10780 Diff 25876 src/infrastructure/javelin/Javelin.php

Changeset View

Standalone View

	<?php			<?php

	final class Javelin {			final class Javelin {

	public static function initBehavior($behavior, array $config = array()) {			public static function initBehavior(
				$behavior,
				array $config = array(),
				$source_name = 'phabricator') {
				epriestleyUnsubmitted Not Done Inline Actions In this codebase, prefer `$source_name = 'phabricator'` to establish a default scalar parameter value (i.e., an explicit default). This: is clearer for humans when browsing the method signature; is accessible to documentation generators and static analysis; does not generate errors like this one: [2014-11-04 05:54:04] ERROR 2: Missing argument 3 for Javelin::initBehavior(), called in /INSECURE/devtools/phabricator/src/view/page/menu/PhabricatorMainMenuSearchView.php on line 49 and defined at [/INSECURE/devtools/phabricator/src/infrastructure/javelin/Javelin.php:8]" epriestley: In this codebase, prefer `$source_name = 'phabricator'` to establish a default scalar parameter…
				epriestleyUnsubmitted Not Done Inline Actions By convention, indent two spaces. epriestley: By convention, indent two spaces.

	$response = CelerityAPI::getStaticResourceResponse();			$response = CelerityAPI::getStaticResourceResponse();
	$response->initBehavior($behavior, $config);
				$response->initBehavior($behavior, $config, $source_name);
	}			}

	}			}