Differential D10498 Diff 25232 src/lint/linter/ArcanistCppcheckLinter.php

Changeset View

Standalone View

src/lint/linter/ArcanistCppcheckLinter.php

Show First 20 Lines • Show All 80 Lines • ▼ Show 20 Lines	foreach ($errors as $error) {
foreach ($error->getElementsByTagName('location') as $location) {		foreach ($error->getElementsByTagName('location') as $location) {
$message = new ArcanistLintMessage();		$message = new ArcanistLintMessage();
$message->setPath($location->getAttribute('file'));		$message->setPath($location->getAttribute('file'));
$message->setLine($location->getAttribute('line'));		$message->setLine($location->getAttribute('line'));
$message->setCode('Cppcheck');		$message->setCode('Cppcheck');
$message->setName($error->getAttribute('id'));		$message->setName($error->getAttribute('id'));
$message->setDescription($error->getAttribute('msg'));		$message->setDescription($error->getAttribute('msg'));

switch ($error->getAttribute('severity')) {		$severity = $error->getAttribute('severity');
		$message->setSeverity($this->getLintMessageSeverity($severity));

		$messages[] = $message;
		}
		}

		return $messages;
		}

		protected function getDefaultMessageSeverity($code) {
		switch ($code) {
case 'error':		case 'error':
$message->setSeverity(ArcanistLintSeverity::SEVERITY_ERROR);		return ArcanistLintSeverity::SEVERITY_ERROR;
break;		break;
		joshuaspenceUnsubmitted Not Done Inline Actions Dead code. joshuaspence: Dead code.
		case 'warning':
		return ArcanistLintSeverity::SEVERITY_WARNING;
		break;
		joshuaspenceUnsubmitted Not Done Inline Actions Dead code. joshuaspence: Dead code.
		case 'performance':
		case 'style':
		case 'portability':
		case 'information':
		case 'debug':
default:		default:
if ($error->getAttribute('inconclusive')) {		return ArcanistLintSeverity::SEVERITY_ADVICE;
$message->setSeverity(ArcanistLintSeverity::SEVERITY_ADVICE);
} else {
$message->setSeverity(ArcanistLintSeverity::SEVERITY_WARNING);
}
break;		break;
}		}

$messages[] = $message;
}		}

		protected function getLintCodeFromLinterConfigurationKey($code) {
		if (!preg_match('@^[a-z_]+$@', $code)) {
		throw new Exception(
		pht(
		'Unrecognized severity code "%s". Expected a valid cppcheck '.
		'severity code like "%s" or "%s".',
		$code,
		'performance',
		'warning'));
}		}

return $messages;		return $code;
}		}

}		}