Differential D9695 Diff 23261 src/docs/flavor/writing_reviewable_code.diviner

Changeset View

Standalone View

	Show First 20 Lines • Show All 73 Lines • ▼ Show 20 Lines
	We generally follow these practices in Phabricator. The median change size for			We generally follow these practices in Phabricator. The median change size for
	Phabricator is 35 lines.			Phabricator is 35 lines.

	See @{article:Differential User Guide: Large Changes} for information about			See @{article:Differential User Guide: Large Changes} for information about
	reviewing big checkins.			reviewing big checkins.

	= Write Sensible Commit Messages =			= Write Sensible Commit Messages =

	There are lots of resources for this on the internet. All of them say pretty much			There are lots of resources for this on the internet. All of them say pretty
	the same thing; this one does too.			much the same thing; this one does too.

	The single most important thing is: **commit messages should explain //why// you			The single most important thing is: **commit messages should explain //why// you
	are making the change**.			are making the change**.

	Differential attempts to encourage the construction of sensible commit messages,			Differential attempts to encourage the construction of sensible commit messages,
	but can only enforce structure, not content. Structurally, commit messages			but can only enforce structure, not content. Structurally, commit messages
	should probably:			should probably:

	▲ Show 20 Lines • Show All 72 Lines • Show Last 20 Lines