Changeset View
Changeset View
Standalone View
Standalone View
src/view/form/control/AphrontFormTokenizerControl.php
| Show First 20 Lines • Show All 86 Lines • ▼ Show 20 Lines | $map = array( | ||||
| 'authors' => pht('Type a user name...'), | 'authors' => pht('Type a user name...'), | ||||
| 'usersorprojects' => pht('Type a user or project name...'), | 'usersorprojects' => pht('Type a user or project name...'), | ||||
| 'searchowner' => pht('Type a user name...'), | 'searchowner' => pht('Type a user name...'), | ||||
| 'accounts' => pht('Type a user name...'), | 'accounts' => pht('Type a user name...'), | ||||
| 'mailable' => pht('Type a user, project, or mailing list...'), | 'mailable' => pht('Type a user, project, or mailing list...'), | ||||
| 'allmailable' => pht('Type a user, project, or mailing list...'), | 'allmailable' => pht('Type a user, project, or mailing list...'), | ||||
| 'searchproject' => pht('Type a project name...'), | 'searchproject' => pht('Type a project name...'), | ||||
| 'projects' => pht('Type a project name...'), | 'projects' => pht('Type a project name...'), | ||||
| 'workboardcolumns'=> pht('Type a column or project name...'), | |||||
bluehawk: I added a type hint, because it looked strange to have this one be empty when most the other… | |||||
| 'repositories' => pht('Type a repository name...'), | 'repositories' => pht('Type a repository name...'), | ||||
| 'packages' => pht('Type a package name...'), | 'packages' => pht('Type a package name...'), | ||||
| 'macros' => pht('Type a macro name...'), | 'macros' => pht('Type a macro name...'), | ||||
| 'arcanistproject' => pht('Type an arc project name...'), | 'arcanistproject' => pht('Type an arc project name...'), | ||||
| 'accountsorprojects' => pht('Type a user or project name...'), | 'accountsorprojects' => pht('Type a user or project name...'), | ||||
| 'usersprojectsorpackages' => | 'usersprojectsorpackages' => | ||||
| pht('Type a user, project, or package name...'), | pht('Type a user, project, or package name...'), | ||||
| ); | ); | ||||
| return idx($map, $request); | return idx($map, $request); | ||||
| } | } | ||||
| } | } | ||||
I added a type hint, because it looked strange to have this one be empty when most the other fields had one. Should I change that?
{F168174}
Without the type hint:
{F168178}
Additionally, because I've made it so the type hinting works on the column OR the project name, I think it's beneficial to inform the user that they can type either.