Changeset View
Changeset View
Standalone View
Standalone View
.arclint
- This file was added.
| { | |||||
| "exclude": [ | |||||
| "(^externals/)", | |||||
| "(\\.lint-test$)" | |||||
| ], | |||||
| "linters": { | |||||
| "filename": { | |||||
| "type": "filename" | |||||
| }, | |||||
| "javelin": { | |||||
| "type": "javelin", | |||||
| "include": "(\\.js$)", | |||||
| "exclude": [ | |||||
| "(^externals/JsShrink/)", | |||||
| "(^support/aphlict/)", | |||||
| "(^webroot/rsrc/externals/raphael/)" | |||||
epriestley: This doesn't actually exist anymore, it's in `webroot/rsrc/externals/raphael/` now. Not this… | |||||
| ] | |||||
| }, | |||||
| "jshint": { | |||||
| "type": "jshint", | |||||
| "include": "(\\.js$)", | |||||
| "exclude": [ | |||||
| "(^externals/JsShrink/)", | |||||
| "(^webroot/rsrc/externals/raphael/)" | |||||
| ] | |||||
Not Done Inline ActionsAs above. epriestley: As above. | |||||
| }, | |||||
| "generated": { | |||||
| "type": "generated" | |||||
| }, | |||||
| "merge-conflict": { | |||||
| "type": "merge-conflict" | |||||
| }, | |||||
| "nolint": { | |||||
| "type": "nolint" | |||||
| }, | |||||
| "phutil-xhpast": { | |||||
| "type": "phutil-xhpast", | |||||
| "include": "(\\.php$)", | |||||
| "phutil-xhpast.deprecated.functions": { | |||||
| "phutil_escape_html": "The phutil_escape_html() function is deprecated. Raw strings passed to phutil_tag() or hsprintf() are escaped automatically." | |||||
Not Done Inline ActionsThis needs more code to work? We should probably namespace the option -- but we could also just remove the configuration and deal with this elsewhere, since there is only one remaining call to this function (phutil_escape_html()) anywhere in the codebase, so this warning has done its job, essentially. epriestley: This needs more code to work? We should probably namespace the option -- but we could also just… | |||||
Not Done Inline ActionsAh whoops. I think that I didn't commit one of the files (ArcanistPhutilXHPASTLinter). I generally agree with you regarding removing this if it is basically not needed anymore. However, the deprecated functions concept is sort of neat and could have use outside of Phabricator, in which case moving it to ArcanistXHPASTLinter makes sense. joshuaspence: Ah whoops. I think that I didn't commit one of the files (`ArcanistPhutilXHPASTLinter`).
I… | |||||
Not Done Inline Actionsjoshuaspence: Oh, of course... `ArcanistPhutilXHPASTLinter` is in rARC not in rP. | |||||
| } | |||||
| }, | |||||
| "text": { | |||||
| "type": "text" | |||||
| }, | |||||
| "spelling": { | |||||
| "type": "spelling" | |||||
| }, | |||||
| "xhpast": { | |||||
| "type": "xhpast", | |||||
| "include": "(\\.php$)", | |||||
| "severity": { | |||||
| "16": "advice", | |||||
| "29": "warning", | |||||
| "31": "error", | |||||
| "34": "error", | |||||
| "35": "error" | |||||
| } | |||||
| } | |||||
| } | |||||
| } | |||||
This doesn't actually exist anymore, it's in webroot/rsrc/externals/raphael/ now. Not this diff's fault, but might as well fix it.