Changeset View
Changeset View
Standalone View
Standalone View
src/applications/herald/adapter/HeraldAdapter.php
| <?php | <?php | ||||
| /** | /** | ||||
| * @group herald | * @group herald | ||||
| */ | */ | ||||
| abstract class HeraldAdapter { | abstract class HeraldAdapter { | ||||
| const FIELD_TITLE = 'title'; | const FIELD_TITLE = 'title'; | ||||
| const FIELD_BODY = 'body'; | const FIELD_BODY = 'body'; | ||||
| const FIELD_AUTHOR = 'author'; | const FIELD_AUTHOR = 'author'; | ||||
| const FIELD_ASSIGNEE = 'assignee'; | |||||
| const FIELD_REVIEWER = 'reviewer'; | const FIELD_REVIEWER = 'reviewer'; | ||||
| const FIELD_REVIEWERS = 'reviewers'; | const FIELD_REVIEWERS = 'reviewers'; | ||||
| const FIELD_COMMITTER = 'committer'; | const FIELD_COMMITTER = 'committer'; | ||||
| const FIELD_CC = 'cc'; | const FIELD_CC = 'cc'; | ||||
| const FIELD_TAGS = 'tags'; | const FIELD_TAGS = 'tags'; | ||||
| const FIELD_DIFF_FILE = 'diff-file'; | const FIELD_DIFF_FILE = 'diff-file'; | ||||
| const FIELD_DIFF_CONTENT = 'diff-content'; | const FIELD_DIFF_CONTENT = 'diff-content'; | ||||
| const FIELD_DIFF_ADDED_CONTENT = 'diff-added-content'; | const FIELD_DIFF_ADDED_CONTENT = 'diff-added-content'; | ||||
| ▲ Show 20 Lines • Show All 126 Lines • ▼ Show 20 Lines | public function getFields() { | ||||
| ); | ); | ||||
| } | } | ||||
| public function getFieldNameMap() { | public function getFieldNameMap() { | ||||
| return array( | return array( | ||||
| self::FIELD_TITLE => pht('Title'), | self::FIELD_TITLE => pht('Title'), | ||||
| self::FIELD_BODY => pht('Body'), | self::FIELD_BODY => pht('Body'), | ||||
| self::FIELD_AUTHOR => pht('Author'), | self::FIELD_AUTHOR => pht('Author'), | ||||
| self::FIELD_ASSIGNEE => pht('Assignee'), | |||||
| self::FIELD_COMMITTER => pht('Committer'), | self::FIELD_COMMITTER => pht('Committer'), | ||||
| self::FIELD_REVIEWER => pht('Reviewer'), | self::FIELD_REVIEWER => pht('Reviewer'), | ||||
| self::FIELD_REVIEWERS => pht('Reviewers'), | self::FIELD_REVIEWERS => pht('Reviewers'), | ||||
| self::FIELD_CC => pht('CCs'), | self::FIELD_CC => pht('CCs'), | ||||
| self::FIELD_TAGS => pht('Tags'), | self::FIELD_TAGS => pht('Tags'), | ||||
| self::FIELD_DIFF_FILE => pht('Any changed filename'), | self::FIELD_DIFF_FILE => pht('Any changed filename'), | ||||
| self::FIELD_DIFF_CONTENT => pht('Any changed file content'), | self::FIELD_DIFF_CONTENT => pht('Any changed file content'), | ||||
| self::FIELD_DIFF_ADDED_CONTENT => pht('Any added file content'), | self::FIELD_DIFF_ADDED_CONTENT => pht('Any added file content'), | ||||
| ▲ Show 20 Lines • Show All 63 Lines • ▼ Show 20 Lines | switch ($field) { | ||||
| case self::FIELD_AUTHOR: | case self::FIELD_AUTHOR: | ||||
| case self::FIELD_COMMITTER: | case self::FIELD_COMMITTER: | ||||
| case self::FIELD_REVIEWER: | case self::FIELD_REVIEWER: | ||||
| case self::FIELD_PUSHER: | case self::FIELD_PUSHER: | ||||
| return array( | return array( | ||||
| self::CONDITION_IS_ANY, | self::CONDITION_IS_ANY, | ||||
| self::CONDITION_IS_NOT_ANY, | self::CONDITION_IS_NOT_ANY, | ||||
| ); | ); | ||||
| case self::FIELD_REPOSITORY: | case self::FIELD_REPOSITORY: | ||||
| case self::FIELD_ASSIGNEE: | |||||
epriestley: I think this field should use this set of conditions instead, because a task may not be… | |||||
| return array( | return array( | ||||
| self::CONDITION_IS_ANY, | self::CONDITION_IS_ANY, | ||||
| self::CONDITION_IS_NOT_ANY, | self::CONDITION_IS_NOT_ANY, | ||||
| self::CONDITION_EXISTS, | self::CONDITION_EXISTS, | ||||
| self::CONDITION_NOT_EXISTS, | self::CONDITION_NOT_EXISTS, | ||||
| ); | ); | ||||
| case self::FIELD_TAGS: | case self::FIELD_TAGS: | ||||
| case self::FIELD_REVIEWERS: | case self::FIELD_REVIEWERS: | ||||
| ▲ Show 20 Lines • Show All 741 Lines • Show Last 20 Lines | |||||
I think this field should use this set of conditions instead, because a task may not be assigned, so "Assignee does not exist" is a meaningful filter for finding unowned tasks.