Differential D7498 Diff 16921 src/applications/harbormaster/storage/build/HarbormasterBuild.php

Changeset View

Standalone View

src/applications/harbormaster/storage/build/HarbormasterBuild.php

	<?php			<?php

	final class HarbormasterBuild extends HarbormasterDAO			final class HarbormasterBuild extends HarbormasterDAO
	implements PhabricatorPolicyInterface {			implements PhabricatorPolicyInterface {

	protected $buildablePHID;			protected $buildablePHID;
	protected $buildPlanPHID;			protected $buildPlanPHID;
	protected $buildStatus;			protected $buildStatus;

	private $buildable = self::ATTACHABLE;			private $buildable = self::ATTACHABLE;
	private $buildPlan = self::ATTACHABLE;			private $buildPlan = self::ATTACHABLE;

				/**
				* Not currently being built.
				*/
				const STATUS_INACTIVE = 'inactive';

				/**
				* Pending pick up by the Harbormaster daemon.
				*/
				const STATUS_PENDING = 'pending';

				/**
				* Waiting for a resource to be allocated (not yet relevant).
				*/
				const STATUS_WAITING = 'waiting';

				/**
				* Current building the buildable.
				*/
				const STATUS_BUILDING = 'building';

				/**
				* The build has passed.
				*/
				const STATUS_PASSED = 'passed';

				/**
				* The build has failed.
				*/
				const STATUS_FAILED = 'failed';
				epriestleyUnsubmitted Not Done Inline Actions These seem reasonable to me. Some other states we might need eventually: Error: we tried to execute the build but hit an unexpected exception or something, or the build plan is garbage, or whatever. Partial Success: the build was fine but the documentation didn't generate or something like that? Something like "non-blocking build steps". This is probably far away. It might be more important at the Buildable level than the Build level, since separating docs out into a separate build plan is probably a better strategy. But if the documentation needs artifacts from this build plan, maybe it ends up in here some of the time. Paused/Aborted: User intervention? Not sure we'll need this. epriestley: These seem reasonable to me. Some other states we might need eventually: - Error: we tried…

	public static function initializeNewBuild(PhabricatorUser $actor) {			public static function initializeNewBuild(PhabricatorUser $actor) {
	return id(new HarbormasterBuild())			return id(new HarbormasterBuild())
	->setBuildStatus('building'); // TODO: Sort this.			->setBuildStatus(self::STATUS_INACTIVE);
	}			}

	public function getConfiguration() {			public function getConfiguration() {
	return array(			return array(
	self::CONFIG_AUX_PHID => true,			self::CONFIG_AUX_PHID => true,
	) + parent::getConfiguration();			) + parent::getConfiguration();
	}			}

	▲ Show 20 Lines • Show All 57 Lines • Show Last 20 Lines