Page MenuHomePhabricator

Allow to adjust the visibility for global rules
Closed, InvalidPublic

Description

I think it would be a good possibility, if you can change the visibility of the global rules, because you can block for example commits, diffs, which contains a passwort (already possible), but you can't put in specific data, because every user will be able to see the data, if you don't restrict whole herald to only a few users.

A alternative way: Allow to let herald search for specific secrets from passphrase.

Event Timeline

Luke081515.2 updated the task description. (Show Details)
Luke081515.2 added projects: Herald, Policy.
Luke081515.2 added a subscriber: Luke081515.2.

Sorry, I don't understand, why you closed this. The problem is:

  • You can block commits, for example, if you don't want to see private data there
    • But if you want to block private data, you need to put in that data in a global herald rule, which is public visible
      • But if you don't use regex, you can block private data, yes, but everyone who can access herald, can see the data, so this feature is not very useful at the moment.

We prefer people follow our posted guidelines on filing feature requests. We don't take feature requests that don't state a problem. Specifically "feature does not exist" does not satisfy our criteria for requesting features.

More specifically we'd prefer if people:

  1. Use Phabricator (in production)
  2. Have users run into problems (in production)
  3. Tell us what those problems are

It might be we end up at the same solution, or we have something larger planned that covers lots of other edge cases. Mostly though, even if we take a new feature request, it could be years before coding would occur. We're very small (2 people) and have limited ability to tackle edge case requests. You're best bet is always to just describe the problem and we'll help find a solution.

You may also be interested in T9212 which explains a bit better why "free support" is increasing burdensome for the upstream.