Page MenuHomePhabricator

Audit shortcuts for accepting commit
Closed, DuplicatePublic

Description

One of the most common tasks in Audit is marking a commit as accepted, but there's no quick way of doing so. You have to scroll to the bottom of the page (or press z), change "Action" from "Comment" to "Accept Commit", and press Submit.

Possible solutions:

  • An "Accept Commit" button at the top and/or bottom of the page
  • A shortcut key that scrolls to Creative Account, sets action to "Accept Commit" and sets the focus to the comment box or to the Submit button

Event Timeline

joshkel raised the priority of this task from to Wishlist.
joshkel updated the task description. (Show Details)
joshkel added a subscriber: joshkel.
chad added a subscriber: chad.

Generally speaking, we don't preface one developer workflow over another. Otherwise, we end up with special buttons everywhere, for everyone. T5815 is where we're likely to go to making bulk workflows in Phabricator easier, hopefully it solves you problem.

Accepting an audit seems like the common or expected action of everyone using Audit, and therefore worth streamlining (similar to how Ctrl-Enter streamlines posting a comment), rather than being one particular developer workflow.

In other words, in reading the linked issues and this comment in particular, I found myself agreeing about selecting actions being cumbersome, wanting one-click access to common actions, and how to take actions being slightly unintuitive at first.

I understand concerns about UI clutter, the complexities of UX design, etc., and I don't mean to rehash past debates, so please consider this merely one more data point as you design your app. Thanks for your reply, and I'll follow T5815.