Page MenuHomePhabricator
Create Task
Maniphest T6266

TYPE_MANIPHEST_DIDEDITTASK trigger seems inconsistent
Closed, InvalidPublic
Actions

Description

I am trying to implement a listener for TYPE_MANIPHEST_DIDEDITTASK.
This is what I expect should happen:
The event should get triggered when

  • I create a new Maniphest Task
  • I click on the edit Icon (the pencil icon) next to each of the Tasks, seen on the page which has list of already created Tasks.
  • I click on the "Edit Task" (string next to pencil icon) which I see when I select a task and go into the task details

My observation is that the event gets triggered only when I click on the edit Icon (the pencil icon) next to each of the Tasks, seen on the page which has list of already created Tasks. And does not get triggered in the other 2 scenarios.

Event Timeline

• mridus created this task.Oct 8 2014, 12:20 AM
• mridus raised the priority of this task from to Needs Triage.
• mridus updated the task description. (Show Details)
• mridus added a project: Maniphest.
• mridus added a subscriber: • mridus.
chad renamed this task from TYPE_MANIPHEST_DIDEDITTASK observation to TYPE_MANIPHEST_DIDEDITTASK trigger seems inconsistent.Oct 8 2014, 12:27 AM
chad updated the task description. (Show Details)
btrahan closed this task as Invalid.Oct 8 2014, 8:13 PM
btrahan claimed this task.

See https://secure.phabricator.com/book/phabricator/article/events/#maniphest-did-edit-task

Generally, this event gets called AFTER you actually edit the task. More subtly, any transaction - say leaving a comment, or adjusting the priority of the task in a list - also counts as an edit.

• mridus added a comment.Oct 8 2014, 8:55 PM

I understand that the event gets triggered after the edit, which means when I click on the "Save Task" button. But does it matter that I arrived at the screen that shows the task details and save task button from the edit icon on the list of tasks page, or when the edit icon is clicked inside the task? I would expect that the event gets triggered every time user clicks on "Save Task" button no matter how the user arrives at that screen. My observation is that it gets triggered only in 1 scenario

chad added a subscriber: chad.EditedOct 8 2014, 9:49 PM

Can you paste your event listener here or via Paste? We don't track where the edit comes from.

btrahan added a comment.EditedOct 8 2014, 10:06 PM

@mridus - it doesn't matter; its all about the save / writing a transaction. All edits end up hitting ManiphestTaskEditController and said controller correctly sends out the event right after the save call.

btrahan added a comment.Oct 8 2014, 10:08 PM

You can see this bit of code here -

https://secure.phabricator.com/diffusion/P/browse/master/src/applications/maniphest/controller/ManiphestTaskEditController.php;b6c65719e48a3ef5c5225e0ee69b686c069259c7$310-343

Phabricator · Built by Phacility