Page MenuHomePhabricator

Expand file with comments
Closed, WontfixPublic


Differential collapses files which has no changes between revision updates. This makes it hard to find unreplied comments. It would be nice if files with comments remained expanded.

Event Timeline

igorgatis raised the priority of this task from to Needs Triage.
igorgatis updated the task description. (Show Details)
igorgatis added a project: Differential.
igorgatis added a subscriber: igorgatis.

โœ˜ Merged into T5654.

I'm merging this in mostly because I think the root issue is the same between these tasks, and if we solve things correctly, then everyone should be satisfied.

I get that. Just afraid of T5654 becoming bigger and take too long.

I believe T4896 is reasonably underway, but I don't have any further info than that. There is a lot of technical debt to get through before we can truly start to improve Differential.

Unknown Object (User) added a comment.Jul 30 2014, 3:08 PM

โœ˜ Merged into T4633.

chad added a subscriber: Unknown Object (User).Jul 30 2014, 3:10 PM

@pran1hiva this is a working install, please dont merge tasks.

chad triaged this task as Wishlist priority.Jul 30 2014, 3:32 PM
chad removed a subscriber: Unknown Object (User).
btrahan claimed this task.

I'm making a few guesses here, but I think we should just close this in favor of T1460.

The big guess is that the workflow here is get a whole bunch of feedback in the form of inline comments, and then address some subset of those inline comments, and then update the revision, hoping the remaining inline comments would stick around so you can keep whittling down the list. I think T1460 with the "done" stuff does a better job of this. See T1460#19 for more details on technical spec and what the product will look like.

I think as requested that workflows that aren't this "todo" workflow would suffer from having the comments stick around. In general, the comments are tied to a specific changeset; if a new changeset is added by running arc diff again, etc there are no comments by definition.

I do not think we should merge this since its orthogonal in a way to T1460 - while it may serve similar workflow purposes its a very different way to make the product serve the workflow.